You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Thomas Munro f8ccab0e97 Fix generic read and write barriers for Clang. ... generic-gcc.h maps our read and write barriers to C11 acquire and release fences using compiler builtins, for platforms where we don't have our own hand-rolled assembler. This is apparently enough for GCC, but the C11 memory model is only defined in terms of atomic accesses, and our barriers for non-atomic, non-volatile accesses were not always respected under Clang's stricter interpretation of the standard. This explains the occasional breakage observed on new RISC-V + Clang animal greenfly in lock-free PgAioHandle manipulation code containing a repeating pattern of loads and read barriers. The problem can also be observed in code generated for MIPS and LoongAarch, though we aren't currently testing those with Clang, and on x86, though we use our own assembler there. The scariest aspect is that we use the generic version on very common ARM systems, but it doesn't seem to reorder the relevant code there (or we'd have debugged this long ago). Fix by inserting an explicit compiler barrier. It expands to an empty assembler block declared to have memory side-effects, so registers are flushed and reordering is prevented. In those respects this is like the architecture-specific assembler versions, but the compiler is still in charge of generating the appropriate fence instruction. Done for write barriers on principle, though concrete problems have only been observed with read barriers. Reported-by: Alexander Lakhin <exclusion@gmail.com> Tested-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/d79691be-22bd-457d-9d90-18033b78c40a%40gmail.com Backpatch-through: 13		2 months ago
..
backend	Disallow generated columns in COPY WHERE clause	2 months ago
bin	Fix redundancy in error message	2 months ago
common	Don't put library-supplied -L/-I switches before user-supplied ones.	5 months ago
fe_utils	Fix bug in archive streamer with LZ4 decompression	6 months ago
include	Fix generic read and write barriers for Clang.	2 months ago
interfaces	Simplify newline handling in libpq TAP test	2 months ago
makefiles	pgxs.mk: remove unreachable rule for deleting regress.def.	6 months ago
pl	Fix resource leaks in PL/Python error reporting, redux.	2 months ago
port	Fix POSIX compliance in pgwin32_unsetenv() for "name" argument	2 months ago
template	…
test	Disallow generated columns in COPY WHERE clause	2 months ago
timezone	Update time zone data files to tzdata release 2025b.	8 months ago
tools	ci: Improve OpenBSD core dump backtrace handling.	2 months ago
tutorial	Doc: simplify the tutorial's window-function examples.	11 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Don't put library-supplied -L/-I switches before user-supplied ones.	5 months ago
Makefile.shlib	Use exported symbols list on macOS for loadable modules as well	7 months ago
meson.build	Update copyright for 2025	12 months ago
nls-global.mk	Fix update-po for the PGXS case	2 months ago