You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 7c87284940 Fix failure for generated column with a not-null domain constraint. ... If a GENERATED column is declared to have a domain data type where the domain's constraints disallow null values, INSERT commands failed because we built a targetlist that included coercing a null constant to the domain's type. The failure occurred even when the generated value would have been perfectly OK. This is adjacent to the issues fixed in 0da39aa76, but we didn't notice for lack of testing a domain with such a constraint. We aren't going to use the result of the targetlist entry for the generated column --- ExecComputeStoredGenerated will overwrite it. So it's not really necessary that it have the exact datatype of the generated column. This patch fixes the problem by changing the targetlist entry to be a null Const of the domain's base type, which should be sufficiently legal. (We do have to tweak ExecCheckPlanOutput to accept the situation, though.) This has been broken since we implemented generated columns. However, this patch only applies easily as far back as v14, partly because I (tgl) only carried 0da39aa76 back that far, but mostly because v14 significantly refactored the handling of INSERT/UPDATE targetlists. Given the lack of field complaints and the short remaining support lifetime of v13, I judge the cost-benefit ratio not good for devising a version that would work in v13. Reported-by: jian he <jian.universality@gmail.com> Author: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxG59tip2+9h=rEv-ykOFjt0cbsPVchhi0RTij8bABBA0Q@mail.gmail.com Backpatch-through: 14		5 months ago
..
backend	Fix failure for generated column with a not-null domain constraint.	5 months ago
bin	pg_combinebackup: Fix incorrect code documentation	5 months ago
common	Harmonize function parameter names for Postgres 18.	5 months ago
fe_utils	add new list type simple_oid_string_list to fe-utils/simple_list	5 months ago
include	Harmonize function parameter names for Postgres 18.	5 months ago
interfaces	Mark sslkeylogfile as Debug option	5 months ago
makefiles	Add support for basic NUMA awareness	5 months ago
pl	plpython: Add test for returning Python set from SETOF function	5 months ago
port	Cleanup of pg_numa.c	5 months ago
template	…
test	Fix failure for generated column with a not-null domain constraint.	5 months ago
timezone	pg_noreturn to replace pg_attribute_noreturn()	6 months ago
tools	Fix recently introduced typos	5 months ago
tutorial	Doc: simplify the tutorial's window-function examples.	8 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Add support for basic NUMA awareness	5 months ago
Makefile.shlib	…
meson.build	Update copyright for 2025	8 months ago
nls-global.mk	…