You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 66ec01dc41 Align the data block sizes of pg_dump's various compression modes. ... After commit fe8192a95, compress_zstd.c tends to produce data block sizes around 128K, and we don't really have any control over that unless we want to overrule ZSTD_CStreamOutSize(). Which seems like a bad idea. But let's try to align the other compression modes to produce block sizes roughly comparable to that, so that pg_restore's skip-data performance isn't enormously different for different modes. gzip compression can be brought in line simply by setting DEFAULT_IO_BUFFER_SIZE = 128K, which this patch does. That increases some unrelated buffer sizes, but none of them seem problematic for modern platforms. lz4's idea of appropriate block size is highly nonlinear: if we just increase DEFAULT_IO_BUFFER_SIZE then the output blocks end up around 200K. I found that adjusting the slop factor in LZ4State_compression_init was a not-too-ugly way of bringing that number roughly into line. With compress = none you get data blocks the same sizes as the table rows, which seems potentially problematic for narrow tables. Introduce a layer of buffering to make that case match the others. Comments in compress_io.h and 002_pg_dump.pl suggest that if we increase DEFAULT_IO_BUFFER_SIZE then we need to increase the amount of data fed through the tests in order to improve coverage. I've not done that here, leaving it for a separate patch. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/3515357.1760128017@sss.pgh.pa.us		2 months ago
..
backend	Remove partColsUpdated.	2 months ago
bin	Align the data block sizes of pg_dump's various compression modes.	2 months ago
common	Fix compiler warnings around _CRT_glob	3 months ago
fe_utils	Introduce frontend API able to retrieve the contents of PG_VERSION	2 months ago
include	Remove partColsUpdated.	2 months ago
interfaces	Cleanup NAN code in float.h, too.	3 months ago
makefiles	Remove traces of support for Sun Studio compiler	4 months ago
pl	plpython: Remove support for major version conflict detection	2 months ago
port	Fix incorrect message-printing in win32security.c.	3 months ago
template	Remove traces of support for Sun Studio compiler	4 months ago
test	Fix EPQ crash from missing partition directory in EState	2 months ago
timezone	Generate GUC tables from .dat file	4 months ago
tools	Align the data block sizes of pg_dump's various compression modes.	2 months ago
tutorial	Fix compile of src/tutorial/funcs.c	3 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Remove traces of support for Sun Studio compiler	4 months ago
Makefile.shlib	…
meson.build	…
nls-global.mk	…