You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 6db27037b9 Fix portability issues with parsing of recovery_target_xid ... The parsing of this parameter has been using strtoul(), which is not portable across platforms. On most Unix platforms, unsigned long has a size of 64 bits, while on Windows it is 32 bits. It is common in recovery scenarios to rely on the output of txid_current() or even the newer pg_current_xact_id() to get a transaction ID for setting up recovery_target_xid. The value returned by those functions includes the epoch in the computed result, which would cause strtoul() to fail where unsigned long has a size of 32 bits once the epoch is incremented. WAL records and 2PC data include only information about 32-bit XIDs and it is not possible to have XIDs across more than one epoch, so discarding the high bits from the transaction ID set has no impact on recovery. On the contrary, the use of strtoul() prevents a consistent behavior across platforms depending on the size of unsigned long. This commit changes the parsing of recovery_target_xid to use pg_strtouint64() instead, available down to 9.6. There is one TAP test stressing recovery with recovery_target_xid, where a tweak based on pg_reset{xlog,wal} is added to bump the XID epoch so as this change gets tested, as per an idea from Alexander Lakhin. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/16780-107fd0c0385b1035@postgresql.org Backpatch-through: 9.6		5 years ago
..
backend	Fix portability issues with parsing of recovery_target_xid	5 years ago
bin	Fixes for pg_dump.c regarding multiranges	5 years ago
common	Refactor logic to check for ASCII-only characters in string	5 years ago
fe_utils	Remove incorrect %s in string	5 years ago
include	Disallow SRFs when considering sorts below Gather Merge	5 years ago
interfaces	Move SHA2 routines to a new generic API layer for crypto hashes	5 years ago
makefiles	Remove libpq.rc, use win32ver.rc for libpq	6 years ago
pl	Multirange datatypes	5 years ago
port	Remove ability to independently select random number generator	5 years ago
template	On macOS, use -isysroot in link steps as well as compile steps.	5 years ago
test	Fix portability issues with parsing of recovery_target_xid	5 years ago
timezone	Improve hash_create()'s API for some added robustness.	5 years ago
tools	Multirange datatypes	5 years ago
tutorial	Remove support for postfix (right-unary) operators.	5 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Remove the option to build thread_test.c outside configure.	5 years ago
Makefile.global.in	Split Makefile symbol CFLAGS_VECTOR into two symbols.	5 years ago
Makefile.shlib	Add PostgreSQL home page to --help output	6 years ago
nls-global.mk	NLS: Fix backend gettext triggers	6 years ago