You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 207d5a656e Fix mishandling of equivalence-class tests in parameterized plans. ... Given a three-or-more-way equivalence class, such as X.Y = Y.Y = Z.Z, it was possible for the planner to omit one of the quals needed to enforce that all members of the equivalence class are actually equal. This only happened in the case of a parameterized join node for two of the relations, that is a plan tree like Nested Loop -> Scan X -> Nested Loop -> Scan Y -> Scan Z Filter: Z.Z = X.X The eclass machinery normally expects to apply X.X = Y.Y when those two relations are joined, but in this shape of plan tree they aren't joined until the top node --- and, if the lower nested loop is marked as parameterized by X, the top node will assume that the relevant eclass condition(s) got pushed down into the lower node. On the other hand, the scan of Z assumes that it's only responsible for constraining Z.Z to match any one of the other eclass members. So one or another of the required quals sometimes fell between the cracks, depending on whether consideration of the eclass in get_joinrel_parampathinfo() for the lower nested loop chanced to generate X.X = Y.Y or X.X = Z.Z as the appropriate constraint there. If it generated the latter, it'd erroneously suppose that the Z scan would take care of matters. To fix, force X.X = Y.Y to be generated and applied at that join node when this case occurs. This is *extremely* hard to hit in practice, because various planner behaviors conspire to mask the problem; starting with the fact that the planner doesn't really like to generate a parameterized plan of the above shape. (It might have been impossible to hit it before we tweaked things to allow this plan shape for star-schema cases.) Many thanks to Alexander Kirkouski for submitting a reproducible test case. The bug can be demonstrated in all branches back to 9.2 where parameterized paths were introduced, so back-patch that far.		10 years ago
..
clauses.h	Fix costing for parallel aggregation.	10 years ago
cost.h	Use Foreign Key relationships to infer multi-column join selectivity	10 years ago
geqo.h	…
geqo_copy.h	…
geqo_gene.h	…
geqo_misc.h	…
geqo_mutation.h	…
geqo_pool.h	…
geqo_random.h	…
geqo_recombination.h	…
geqo_selection.h	…
joininfo.h	…
orclauses.h	…
pathnode.h	Allow aggregate transition states to be serialized and deserialized.	10 years ago
paths.h	Fix mishandling of equivalence-class tests in parameterized plans.	10 years ago
placeholder.h	…
plancat.h	Directly modify foreign tables.	10 years ago
planmain.h	Run pgindent on a batch of (mostly-planner-related) source files.	10 years ago
planner.h	Redefine create_upper_paths_hook as being invoked once per upper relation.	10 years ago
predtest.h	…
prep.h	Make the upper part of the planner work by generating and comparing Paths.	10 years ago
restrictinfo.h	…
subselect.h	Make the upper part of the planner work by generating and comparing Paths.	10 years ago
tlist.h	Support parallel aggregation.	10 years ago
var.h	Give pull_var_clause() reject/recurse/return behavior for WindowFuncs too.	10 years ago