You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 7d8f595779 Create infrastructure to reliably prevent leakage of PGresults. ... Commit 232d8caea fixed a case where postgres_fdw could lose track of a PGresult object, resulting in a process-lifespan memory leak. But I have little faith that there aren't other potential PGresult leakages, now or in future, in the backend modules that use libpq. Therefore, this patch proposes infrastructure that makes all PGresults returned from libpq act as though they are palloc'd in the CurrentMemoryContext (with the option to relocate them to another context later). This should greatly reduce the risk of careless leaks, and it also permits removal of a bunch of code that attempted to prevent such leaks via PG_TRY blocks. This patch adds infrastructure that wraps each PGresult in a "libpqsrv_PGresult" that provides a memory context reset callback to PQclear the PGresult. Code using this abstraction is inherently memory-safe to the same extent as we are accustomed to in most backend code. Furthermore, we add some macros that automatically redirect calls of the libpq functions concerned with PGresults to use this infrastructure, so that almost no source-code changes are needed to wheel this infrastructure into place in all the backend code that uses libpq. Perhaps in future we could create similar infrastructure for PGconn objects, but there seems less need for that. This patch just creates the infrastructure and makes relevant code use it, including reverting 232d8caea in favor of this mechanism. A good deal of follow-on simplification is possible now that we don't have to be so cautious about freeing PGresults, but I'll put that in a separate patch. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/2976982.1748049023@sss.pgh.pa.us		5 months ago
..
expected	Reduce "Var IS [NOT] NULL" quals during constant folding	5 months ago
sql	Reduce "Var IS [NOT] NULL" quals during constant folding	5 months ago
t	Fix typos and grammar in the code	8 months ago
.gitignore	…
Makefile	postgres_fdw: SCRAM authentication pass-through	11 months ago
connection.c	Remove translation marker from libpq-be-fe-helpers.h.	5 months ago
deparse.c	Fix a typo in the deparseArrayCoerceExpr() header comment	5 months ago
meson.build	meson: Increase minimum version to 0.57.2	6 months ago
option.c	oauth: Disallow OAuth connections via postgres_fdw/dblink	8 months ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	5 years ago
postgres_fdw--1.0.sql	…
postgres_fdw--1.1--1.2.sql	postgres_fdw: Extend postgres_fdw_get_connections to return remote backend PID.	10 months ago
postgres_fdw.c	Create infrastructure to reliably prevent leakage of PGresults.	5 months ago
postgres_fdw.control	postgres_fdw: Add "used_in_xact" column to postgres_fdw_get_connections().	1 year ago
postgres_fdw.h	Create infrastructure to reliably prevent leakage of PGresults.	5 months ago
shippable.c	Update copyright for 2025	12 months ago