You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 8735978e7a Pad XLogReaderState's main_data buffer more aggressively. ... Originally, we palloc'd this buffer just barely big enough to hold the largest xlog record seen so far. It turns out that that can result in valgrind complaints, because some compilers will emit code that assumes it can safely fetch padding bytes at the end of a struct, and those padding bytes were unallocated so far as aset.c was concerned. We can fix that by MAXALIGN'ing the palloc request size, ensuring that it is big enough to include any possible padding that might've been omitted from the on-disk record. An additional objection to the original coding is that it could result in many repeated palloc cycles, in the worst case where we see a series of gradually larger xlog records. We can ameliorate that cheaply by imposing a minimum buffer size that's large enough for most xlog records. BLCKSZ/2 was chosen after a bit of discussion. In passing, remove an obsolete comment in struct xl_heap_new_cid that the combocid field is free due to alignment considerations. Perhaps that was true at some point, but it's not now. Back-patch to 9.5 where this code came in. Discussion: https://postgr.es/m/E1eHa4J-0006hI-Q8@gemulon.postgresql.org		8 years ago
..
amapi.h	Phase 3 of pgindent updates.	9 years ago
amvalidate.h	Phase 2 of pgindent updates.	9 years ago
attnum.h	Phase 2 of pgindent updates.	9 years ago
brin.h	Phase 2 of pgindent updates.	9 years ago
brin_internal.h	Phase 2 of pgindent updates.	9 years ago
brin_page.h	Phase 2 of pgindent updates.	9 years ago
brin_pageops.h	Phase 2 of pgindent updates.	9 years ago
brin_revmap.h	Phase 2 of pgindent updates.	9 years ago
brin_tuple.h	Phase 2 of pgindent updates.	9 years ago
brin_xlog.h	Phase 2 of pgindent updates.	9 years ago
bufmask.h	For wal_consistency_checking, mask page checksum as well as page LSN.	8 years ago
clog.h	Phase 3 of pgindent updates.	9 years ago
commit_ts.h	Phase 2 of pgindent updates.	9 years ago
genam.h	Phase 3 of pgindent updates.	9 years ago
generic_xlog.h	Phase 2 of pgindent updates.	9 years ago
gin.h	Phase 2 of pgindent updates.	9 years ago
gin_private.h	Fix broken cleanup interlock for GIN pending list.	8 years ago
ginblock.h	Phase 2 of pgindent updates.	9 years ago
ginxlog.h	Phase 2 of pgindent updates.	9 years ago
gist.h	Phase 2 of pgindent updates.	9 years ago
gist_private.h	Add some const decorations to prototypes	8 years ago
gistscan.h	Phase 2 of pgindent updates.	9 years ago
gistxlog.h	Split index xlog headers from other private index headers.	9 years ago
hash.h	Remove lsn from HashScanPosData.	8 years ago
hash_xlog.h	Change TRUE/FALSE to true/false	8 years ago
heapam.h	Revert bogus fixes of HOT-freezing bug	8 years ago
heapam_xlog.h	Pad XLogReaderState's main_data buffer more aggressively.	8 years ago
hio.h	Phase 2 of pgindent updates.	9 years ago
htup.h	Phase 2 of pgindent updates.	9 years ago
htup_details.h	Support domains over composite types.	8 years ago
itup.h	Change tupledesc->attrs[n] to TupleDescAttr(tupledesc, n).	8 years ago
multixact.h	Phase 2 of pgindent updates.	9 years ago
nbtree.h	Minor code-cleanliness improvements for btree.	8 years ago
nbtxlog.h	Remove dedicated B-tree root-split record types.	9 years ago
parallel.h	Provide DSM segment to ExecXXXInitializeWorker functions.	8 years ago
printsimple.h	Phase 2 of pgindent updates.	9 years ago
printtup.h	Improve performance of SendRowDescriptionMessage.	8 years ago
reloptions.h	Add some const decorations to prototypes	8 years ago
relscan.h	Use atomic ops to hand out pages to scan in parallel scan.	9 years ago
rewriteheap.h	Phase 2 of pgindent updates.	9 years ago
rmgr.h	Phase 2 of pgindent updates.	9 years ago
rmgrlist.h	hash: Support WAL consistency checking.	9 years ago
sdir.h	Phase 2 of pgindent updates.	9 years ago
session.h	Avoid duplicate typedef for SharedRecordTypmodRegistry.	8 years ago
skey.h	Phase 2 of pgindent updates.	9 years ago
slru.h	Change TRUE/FALSE to true/false	8 years ago
spgist.h	Phase 2 of pgindent updates.	9 years ago
spgist_private.h	Phase 2 of pgindent updates.	9 years ago
spgxlog.h	Phase 2 of pgindent updates.	9 years ago
stratnum.h	Phase 2 of pgindent updates.	9 years ago
subtrans.h	Phase 2 of pgindent updates.	9 years ago
sysattr.h	Phase 2 of pgindent updates.	9 years ago
timeline.h	Phase 2 of pgindent updates.	9 years ago
transam.h	Phase 2 of pgindent updates.	9 years ago
tsmapi.h	Phase 2 of pgindent updates.	9 years ago
tupconvert.h	Phase 2 of pgindent updates.	9 years ago
tupdesc.h	Support domains over composite types.	8 years ago
tupmacs.h	Phase 2 of pgindent updates.	9 years ago
tuptoaster.h	Phase 2 of pgindent updates.	9 years ago
twophase.h	Phase 2 of pgindent updates.	9 years ago
twophase_rmgr.h	Phase 2 of pgindent updates.	9 years ago
valid.h	Phase 2 of pgindent updates.	9 years ago
visibilitymap.h	Phase 2 of pgindent updates.	9 years ago
xact.h	Add some const decorations to prototypes	8 years ago
xlog.h	Change TRUE/FALSE to true/false	8 years ago
xlog_internal.h	Add some const decorations to prototypes	8 years ago
xlogdefs.h	Phase 2 of pgindent updates.	9 years ago
xloginsert.h	Phase 2 of pgindent updates.	9 years ago
xlogreader.h	Make WAL segment size configurable at initdb time.	8 years ago
xlogrecord.h	Phase 2 of pgindent updates.	9 years ago
xlogutils.h	Post-PG 10 beta1 pgindent run	9 years ago