You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 84fb27511d Replace off_t by pgoff_t in I/O routines ... PostgreSQL's Windows port has never been able to handle files larger than 2GB due to the use of off_t for file offsets, only 32-bit on Windows. This causes signed integer overflow at exactly 2^31 bytes when trying to handle files larger than 2GB, for the routines touched by this commit. Note that large files are forbidden by ./configure (3c6248a828) and meson (recent change, see 79cd66f28c). This restriction also exists in v16 and older versions for the now-dead MSVC scripts. The code base already defines pgoff_t as __int64 (64-bit) on Windows for this purpose, and some function declarations in headers use it, but many internals still rely on off_t. This commit switches more routines to use pgoff_t, offering more portability, for areas mainly related to file extensions and storage. These are not critical for WAL segments yet, which have currently a maximum size allowed of 1GB (well, this opens the door at allowing a larger size for them). This matters more for segment files if we want to lift the large file restriction in ./configure and meson in the future, which would make sense to remove once/if all traces of off_t are gone from the tree. This can additionally matter for out-of-core code that may want files larger than 2GB in places where off_t is four bytes in size. Note that off_t is still used in other parts of the tree like buffile.c, WAL sender/receiver, base backup, pg_combinebackup, etc. These other code paths can be addressed separately, and their update will be required if we want to remove the large file restriction in the future. This commit is a good first cut in itself towards more portability, hopefully. On Unix-like systems, pgoff_t is defined as off_t, so this change only affects Windows behavior. Author: Bryan Green <dbryan.green@gmail.com> Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/0f238ff4-c442-42f5-adb8-01b762c94ca1@gmail.com		2 months ago
..
backend	Replace off_t by pgoff_t in I/O routines	2 months ago
bin	Add tab completion support for the WAIT FOR command	2 months ago
common	Replace off_t by pgoff_t in I/O routines	2 months ago
fe_utils	Add \pset options for boolean value display	3 months ago
include	Replace off_t by pgoff_t in I/O routines	2 months ago
interfaces	Change coding pattern for CURL_IGNORE_DEPRECATION()	2 months ago
makefiles	Remove traces of support for Sun Studio compiler	5 months ago
pl	Avoid memory leak in validation of a PL/Python trigger function.	3 months ago
port	Replace off_t by pgoff_t in I/O routines	2 months ago
template	Remove traces of support for Sun Studio compiler	5 months ago
test	test_dsa: Avoid leaking LWLock tranches.	2 months ago
timezone	Generate GUC tables from .dat file	5 months ago
tools	Replace off_t by pgoff_t in I/O routines	2 months ago
tutorial	Fix compile of src/tutorial/funcs.c	4 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Remove traces of support for Sun Studio compiler	5 months ago
Makefile.shlib	…
meson.build	…
nls-global.mk	Fix update-po for the PGXS case	3 months ago