You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 896eb5efbd In the planner, delete joinaliasvars lists after we're done with them. ... Although joinaliasvars lists coming out of the parser are quite simple, those lists can contain arbitrarily complex expressions after subquery pullup. We do not perform expression preprocessing on them, meaning that expressions in those lists will not meet the expectations of later phases of the planner (for example, that they do not contain SubLinks). This had been thought pretty harmless, since we don't intentionally touch those lists in later phases --- but Andreas Seltenreich found a case in which adjust_appendrel_attrs() could recurse into a joinaliasvars list and then die on its assertion that it never sees a SubLink. We considered a couple of localized fixes to prevent that specific case from looking at the joinaliasvars lists, but really this seems like a generic hazard for all expression processing in the planner. Therefore, probably the best answer is to delete the joinaliasvars lists from the parsetree at the end of expression preprocessing, so that there are no reachable expressions that haven't been through preprocessing. The case Andreas found seems to be harmless in non-Assert builds, and so far there are no field reports suggesting that there are user-visible effects in other cases. I considered back-patching this anyway, but it turns out that Andreas' test doesn't fail at all in 9.4-9.6, because in those versions adjust_appendrel_attrs contains code (added in commit 842faa714 and removed again in commit 215b43cdc) to process SubLinks rather than complain about them. Barring discovery of another path by which unprocessed joinaliasvars lists can cause trouble, the most prudent compromise seems to be to patch this into v10 but not further. Patch by me, with thanks to Amit Langote for initial investigation and review. Discussion: https://postgr.es/m/87r2tvt9f1.fsf@ansel.ydns.eu		8 years ago
..
backend	In the planner, delete joinaliasvars lists after we're done with them.	8 years ago
bin	Adjust psql \d query to avoid use of @> operator.	8 years ago
common	Rewrite strnlen replacement implementation from 8a241792f9.	8 years ago
fe_utils	Exclude flex-generated code from coverage testing	8 years ago
include	Allow the built-in ordered-set aggregates to share transition state.	8 years ago
interfaces	Exclude flex-generated code from coverage testing	8 years ago
makefiles	Always use -fPIC, not -fpic, when building shared libraries with gcc.	9 years ago
pl	Use Py_RETURN_NONE where suitable	8 years ago
port	Rewrite strnlen replacement implementation from 8a241792f9.	8 years ago
template	Force "restrict" not to be used when compiling with xlc.	8 years ago
test	In the planner, delete joinaliasvars lists after we're done with them.	8 years ago
timezone	Update time zone data files to tzdata release 2017c.	8 years ago
tools	Improve sys/catcache performance.	8 years ago
tutorial	Distinguish selectivity of < from <= and > from >=.	8 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Remove redundant coverage target	9 years ago
Makefile.global.in	Reinstate genhtml --prefix option for non-vpath builds	8 years ago
Makefile.shlib	Remove support for bcc and msvc standalone libpq builds	9 years ago
nls-global.mk	nls-global.mk: search build dir for source files, too	10 years ago