You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 8a22a40b2c Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY ... One code path related to this flavor of ALTER TABLE was checking that the relation to detach has to be a normal table or a partitioned table, which would fail if using the command with a different relation kind. Views, sequences and materialized views cannot be part of a partition tree, so these would cause the command to fail anyway, but the assertion was triggered. Foreign tables can be part of a partition tree, and again the assertion would have failed. The simplest solution is just to remove this assertion, so as we get the same failure as the non-concurrent code path. While on it, add a regression test in postgres_fdw for the concurrent partition detach of a foreign table, as per a suggestion from Alexander Lakhin. Issue introduced in 71f4c8c. Reported-by: Alexander Lakhin Author: Michael Paquier, Alexander Lakhin Reviewed-by: Peter Eisentraut, Kyotaro Horiguchi Discussion: https://postgr.es/m/17339-a9e09aaf38a3457a@postgresql.org Backpatch-through: 14		4 years ago
..
expected	Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY	4 years ago
sql	Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY	4 years ago
.gitignore	…
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	postgres_fdw: Fix unexpected reporting of empty message.	4 years ago
deparse.c	postgres_fdw: Fix issues with generated columns in foreign tables.	4 years ago
option.c	Avoid using ambiguous word "non-negative" in error messages.	4 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	5 years ago
postgres_fdw--1.0.sql	…
postgres_fdw.c	Fix null-pointer crash in postgres_fdw's conversion_error_callback.	4 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	postgres_fdw: Fix issues with generated columns in foreign tables.	4 years ago
shippable.c	Replace remaining uses of "whitelist".	5 years ago