You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 8d148bb8b8 Fix edge case in plpgsql's make_callstmt_target(). ... If the plancache entry for the CALL statement is already stale, it's possible for us to fetch an old procedure OID out of it, and then fail with "cache lookup failed for function NNN". In ordinary usage this never happens because make_callstmt_target is called just once immediately after building the plancache entry. It can be forced however by setting up an erroneous CALL (that causes make_callstmt_target itself to report an error), then dropping/recreating the target procedure, then repeating the erroneous CALL. To fix, use SPI_plan_get_cached_plan() to fetch the plancache's plan, rather than assuming we can use SPI_plan_get_plan_sources(). This shouldn't add any noticeable overhead in the normal case, and in the stale-plan case we'd have had to replan anyway a little further down. The other callers of SPI_plan_get_plan_sources() seem OK, because either they don't need up-to-date plans or they know that the query was just (re) planned. But add some commentary in hopes of not falling into this trap again. Per bug #18574 from Song Hongyu. Back-patch to v14 where this coding was introduced. (Older branches have comparable code, but it's run after any required replanning, so there's no issue.) Discussion: https://postgr.es/m/18574-2ce7ba3249221389@postgresql.org		1 year ago
..
backend	Fix edge case in plpgsql's make_callstmt_target().	1 year ago
bin	Move astreamer (except astreamer_inject) to fe_utils.	1 year ago
common	Make fallback MD5 implementation thread-safe on big-endian systems	1 year ago
fe_utils	Improve file header comments for astramer code.	1 year ago
include	Improve file header comments for astramer code.	1 year ago
interfaces	Revert ECPG's use of pnstrdup()	1 year ago
makefiles	Add -Wmissing-variable-declarations to the standard compilation flags	1 year ago
pl	Fix edge case in plpgsql's make_callstmt_target().	1 year ago
port	Add port/ replacement for strsep()	1 year ago
template	…
test	Refactor/reword some error messages to avoid duplicates	1 year ago
timezone	…
tools	Rename bbstreamer to astreamer.	1 year ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Add -Wmissing-variable-declarations to the standard compilation flags	1 year ago
Makefile.shlib	…
meson.build	…
nls-global.mk	…