postgres

History

Tom Lane 8f1791c618 Fix some cases of indirectly casting away const. Newest versions of gcc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char " value to a target variable that's just "char ". This of course creates a hazard of not getting a compiler warning about scribbling on a string one was not supposed to, so fixing up such cases is good. This patch fixes a dozen or so places where we were doing that. Most are trivial additions of "const" to the target variable, since no actually-hazardous change was occurring. There is one place in ecpg.trailer where we were indeed violating the intention of not modifying a string passed in as "const char *". I believe that's harmless not a live bug, but let's fix it by copying the string before modifying it. There is a remaining trouble spot in ecpg/preproc/variable.c, which requires more complex surgery. I've left that out of this commit because I want to study that code a bit more first. We probably will want to back-patch this once compilers that detect this pattern get into wider circulation, but for now I'm just going to apply it to master to see what the buildfarm says. Thanks to Bertrand Drouvot for finding a couple more spots than I had. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/1324889.1764886170@sss.pgh.pa.us		4 weeks ago
..
backend	Fix some cases of indirectly casting away const.	4 weeks ago
bin	Fix some cases of indirectly casting away const.	4 weeks ago
common	Fix some cases of indirectly casting away const.	4 weeks ago
fe_utils	Add \pset options for boolean value display	2 months ago
include	Rename column slotsync_skip_at to slotsync_last_skip.	4 weeks ago
interfaces	Fix some cases of indirectly casting away const.	4 weeks ago
makefiles	Remove traces of support for Sun Studio compiler	4 months ago
pl	Avoid memory leak in validation of a PL/Python trigger function.	2 months ago
port	Fix some cases of indirectly casting away const.	4 weeks ago
template	Remove traces of support for Sun Studio compiler	4 months ago
test	Fix some cases of indirectly casting away const.	4 weeks ago
timezone	Fix some cases of indirectly casting away const.	4 weeks ago
tools	headerscheck ccache support	1 month ago
tutorial	Fix compile of src/tutorial/funcs.c	3 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Remove traces of support for Sun Studio compiler	4 months ago
Makefile.shlib	Use exported symbols list on macOS for loadable modules as well	7 months ago
meson.build	…
nls-global.mk	Fix update-po for the PGXS case	3 months ago