You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Rowley 9154ededfc Strip off ORDER BY/DISTINCT aggregate pathkeys in create_agg_path ... 1349d2790 added code to adjust the PlannerInfo.group_pathkeys so that ORDER BY / DISTINCT aggregate functions could obtain pre-sorted inputs to allow faster execution. That commit forgot to adjust the pathkeys in create_agg_path(). Some code in there assumed that it was always fine to make the AggPath's pathkeys the same as its subpath's. That seems to have been ok up until 1349d2790, but since that commit adds pathkeys for columns which are within the aggregate function, those columns won't be available above the aggregate node. This can result in "could not find pathkey item to sort" during create_plan(). The fix here is to strip off the additional pathkeys added by adjust_group_pathkeys_for_groupagg(). It seems that the pathkeys here will only ever be group_pathkeys, so all we need to do is check if the length of the pathkey list is longer than the num_groupby_pathkeys and get rid of the additional ones only if we see extras. Reported-by: Justin Pryzby Reviewed-by: Richard Guo Discussion: https://postgr.es/m/ZQhYYRhUxpW3PSf9%40telsasoft.com Backpatch-through: 16, where 1349d2790 was introduced		2 years ago
..
backend	Strip off ORDER BY/DISTINCT aggregate pathkeys in create_agg_path	2 years ago
bin	Fix omission of column-level privileges in selective pg_restore.	2 years ago
common	meson: Add dependencies to perl modules to various script invocations	2 years ago
fe_utils	Pre-beta mechanical code beautification.	2 years ago
include	Fix EvalPlanQual rechecking during MERGE.	2 years ago
interfaces	Translation updates	2 years ago
makefiles	Use --strip-unneeded when stripping static libraries with GNU strip.	2 years ago
pl	Remove environment sensitivity in pl/tcl regression test.	2 years ago
port	Meson: check for pg_config_paths.h left over from make	2 years ago
template	Use unnamed POSIX semaphores on Cygwin.	3 years ago
test	Only evaluate default values as required when doing COPY FROM	2 years ago
timezone	Pre-beta mechanical code beautification.	2 years ago
tools	Fix exception safety bug in typcache.c.	2 years ago
tutorial	Pre-beta mechanical code beautification.	2 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
Makefile.global.in	Suppress macOS warnings about duplicate libraries in link commands.	2 years ago
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2 years ago
meson.build	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
nls-global.mk	Fix for make unportability	3 years ago