postgres

History

Tom Lane c7b7311f61 Avoid doing catalog lookups in postgres_fdw's conversion_error_callback. As in `50371df26`, this is a bad idea since the callback can't really know what error is being thrown and thus whether or not it is safe to attempt catalog accesses. Rather than pushing said accesses into the mainline code where they'd usually be a waste of cycles, we can look at the query's rangetable instead. This change does mean that we'll be printing query aliases (if any were used) rather than the table or column's true name. But that doesn't seem like a bad thing: it's certainly a more useful definition in self-join cases, for instance. In any case, it seems unlikely that any applications would be depending on this detail, so it seems safe to change. Patch by me. Original complaint by Andres Freund; Bharath Rupireddy noted the connection to conversion_error_callback. Discussion: https://postgr.es/m/20210106020229.ne5xnuu6wlondjpe@alap3.anarazel.de		4 years ago
..
expected	Avoid doing catalog lookups in postgres_fdw's conversion_error_callback.	4 years ago
sql	Avoid doing catalog lookups in postgres_fdw's conversion_error_callback.	4 years ago
.gitignore	…
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	Allow TRUNCATE command to truncate foreign tables.	4 years ago
deparse.c	Initial pgindent and pgperltidy run for v14.	4 years ago
option.c	Allow TRUNCATE command to truncate foreign tables.	4 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	4 years ago
postgres_fdw--1.0.sql	…
postgres_fdw.c	Avoid doing catalog lookups in postgres_fdw's conversion_error_callback.	4 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.	4 years ago
shippable.c	Replace remaining uses of "whitelist".	5 years ago