You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane a3bed62d44 Fix low-probability leaks of PGresult objects in the backend. ... We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all three loops simply gave up and returned, forgetting to clear any previously-collected PGresult object. Since those are malloc'd not palloc'd, the oversight results in a process-lifespan memory leak. One instance, in libpqwalreceiver, is of little significance because the walreceiver process would just quit anyway if its connection fails. But we might as well fix it. The other two instances, in postgres_fdw, are somewhat more worrisome because at least in principle the scenario could be repeated, allowing the amount of memory leaked to build up to something worth worrying about. Moreover, in these cases the loops contain CHECK_FOR_INTERRUPTS calls, as well as other calls that could potentially elog(ERROR), providing another way to exit without having cleared the PGresult. Here we need to add PG_TRY logic similar to what exists in quite a few other places in postgres_fdw. Coverity noted the libpqwalreceiver bug; I found the other two cases by checking all calls of PQconsumeInput. Back-patch to all supported versions as appropriate (9.2 lacks postgres_fdw, so this is really quite unexciting for that branch). Discussion: https://postgr.es/m/22620.1497486981@sss.pgh.pa.us		9 years ago
..
expected	psql: Use more consistent capitalization of some output headings	9 years ago
sql	postgres_fdw: Fix join push down with extensions	9 years ago
.gitignore	…
Makefile	Allow postgres_fdw to ship extension funcs/operators for remote execution.	10 years ago
connection.c	Fix low-probability leaks of PGresult objects in the backend.	9 years ago
deparse.c	Post-PG 10 beta1 pgindent run	9 years ago
option.c	Move some things from builtins.h to new header files	9 years ago
postgres_fdw--1.0.sql	…
postgres_fdw.c	Post-PG 10 beta1 pgindent run	9 years ago
postgres_fdw.control	…
postgres_fdw.h	Post-PG 10 beta1 pgindent run	9 years ago
shippable.c	Update copyright via script for 2017	9 years ago