You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier a3ab7a707d Fix corner case with 16kB-long decompression in pgcrypto, take 2 ... A compressed stream may end with an empty packet. In this case decompression finishes before reading the empty packet and the remaining stream packet causes a failure in reading the following data. This commit makes sure to consume such extra data, avoiding a failure when decompression the data. This corner case was reproducible easily with a data length of 16kB, and existed since e94dd6a. A cheap regression test is added to cover this case based on a random, incompressible string. The first attempt of this patch has allowed to find an older failure within the compression logic of pgcrypto, fixed by b9b6105. This involved SLES 15 with z390 where a custom flavor of libz gets used. Bonus thanks to Mark Wong for providing access to the specific environment. Reported-by: Frank Gagnepain Author: Kyotaro Horiguchi, Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/16476-692ef7b84e5fb893@postgresql.org Backpatch-through: 9.5		5 years ago
..
3des.out	Fix some more regression tests (missed these because they're only	17 years ago
blowfish.out	Remove useless whitespace at end of lines	15 years ago
cast5.out	Fix some more regression tests (missed these because they're only	17 years ago
crypt-blowfish.out	pgcrypto: Detect and report too-short crypt() salts.	10 years ago
crypt-des.out	pgcrypto: Detect and report too-short crypt() salts.	10 years ago
crypt-md5.out	SET autocommit no longer needed in /contrib because pg_regress.sh does	23 years ago
crypt-xdes.out	pgcrypto: Detect and report too-short crypt() salts.	10 years ago
des.out	Fix some more regression tests (missed these because they're only	17 years ago
hmac-md5.out	SET autocommit no longer needed in /contrib because pg_regress.sh does	23 years ago
hmac-sha1.out	Fix typos in SQL scripts of pgcrypto	7 years ago
init.out	Convert contrib modules to use the extension facility.	15 years ago
md5.out	SET autocommit no longer needed in /contrib because pg_regress.sh does	23 years ago
pgp-armor.out	Add functions for dealing with PGP armor header lines to pgcrypto.	11 years ago
pgp-compression.out	Fix corner case with 16kB-long decompression in pgcrypto, take 2	5 years ago
pgp-decrypt.out	Fix typos in SQL scripts of pgcrypto	7 years ago
pgp-encrypt.out	pgcrypto: support changing S2K iteration count	10 years ago
pgp-info.out	Fix buffer overrun after incomplete read in pullf_read_max().	11 years ago
pgp-pubkey-decrypt.out	pgcrypto: Report errant decryption as "Wrong key or corrupt data".	11 years ago
pgp-pubkey-encrypt.out	Ooops, missed that a couple of contrib modules have calls to byteacmp.	17 years ago
pgp-zlib-DISABLED.out	Add missing pgcrypto files from previous commit.	21 years ago
rijndael.out	pgcrypto's encrypt() supports AES-128, AES-192, and AES-256	8 years ago
sha1.out	SET autocommit no longer needed in /contrib because pg_regress.sh does	23 years ago
sha2.out	"Annual" pgcrypto update from Marko Kreen:	20 years ago