postgres

History

Michael Paquier 7e8b44f4e0 pg_stat_statements: Fix parameter number gaps in normalized queries pg_stat_statements anticipates that certain constant locations may be recorded multiple times and attempts to avoid calculating a length for these locations in fill_in_constant_lengths(). However, during generate_normalized_query() where normalized query strings are generated, these locations are not excluded from consideration. This could increment the parameter number counter for every recorded occurrence at such a location, leading to an incorrect normalization in certain cases with gaps in the numbers reported. For example, take this query: SELECT WHERE '1' IN ('2'::int, '3'::int::text) Before this commit, it would be normalized like that, with gaps in the parameter numbers: SELECT WHERE $1 IN ($3::int, $4::int::text) However the correct, less confusing one should be like that: SELECT WHERE $1 IN ($2::int, $3::int::text) This commit fixes the computation of the parameter numbers to track the number of constants replaced with an $n by a separate counter instead of the iterator used to loop through the list of locations. The underlying query IDs are not changed, neither are the normalized strings for existing PGSS hash entries. New entries with fresh normalized queries would automatically get reshaped based on the new parameter numbering. Issue discovered while discussing a separate problem for HEAD, but this affects all the stable branches. Author: Sami Imseih <samimseih@gmail.com> Discussion: https://postgr.es/m/CAA5RZ0tzxvWXsacGyxrixdhy3tTTDfJQqxyFBRFh31nNHBQ5qA@mail.gmail.com Backpatch-through: 13		8 months ago
..
expected	pg_stat_statements: Fix parameter number gaps in normalized queries	8 months ago
sql	pg_stat_statements: Fix parameter number gaps in normalized queries	8 months ago
.gitignore	…
Makefile	Add missing query ID reporting in extended query protocol	1 year ago
meson.build	Add missing query ID reporting in extended query protocol	1 year ago
pg_stat_statements--1.0--1.1.sql	…
pg_stat_statements--1.1--1.2.sql	…
pg_stat_statements--1.2--1.3.sql	…
pg_stat_statements--1.3--1.4.sql	…
pg_stat_statements--1.4--1.5.sql	…
pg_stat_statements--1.4.sql	…
pg_stat_statements--1.5--1.6.sql	…
pg_stat_statements--1.6--1.7.sql	…
pg_stat_statements--1.7--1.8.sql	…
pg_stat_statements--1.8--1.9.sql	…
pg_stat_statements--1.9--1.10.sql	…
pg_stat_statements.c	pg_stat_statements: Fix parameter number gaps in normalized queries	8 months ago
pg_stat_statements.conf	…
pg_stat_statements.control	…