You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane aaf10f32a3 Fix assorted bugs in pg_get_partition_constraintdef(). ... It failed if passed a nonexistent relation OID, or one that was a non-heap relation, because of blindly applying heap_open to a user-supplied OID. This is not OK behavior for a SQL-exposed function; we have a project policy that we should return NULL in such cases. Moreover, since pg_get_partition_constraintdef ought now to work on indexes, restricting it to heaps is flat wrong anyway. The underlying function generate_partition_qual() wasn't on board with indexes having partition quals either, nor for that matter with rels having relispartition set but yet null relpartbound. (One wonders whether the person who wrote the function comment blocks claiming that these functions allow a missing relpartbound had ever tested it.) Fix by testing relispartition before opening the rel, and by using relation_open not heap_open. (If any other relkinds ever grow the ability to have relispartition set, the code will work with them automatically.) Also, don't reject null relpartbound in generate_partition_qual. Back-patch to v11, and all but the null-relpartbound change to v10. (It's not really necessary to change generate_partition_qual at all in v10, but I thought s/heap_open/relation_open/ would be a good idea anyway just to keep the code in sync with later branches.) Per report from Justin Pryzby. Discussion: https://postgr.es/m/20180927200020.GJ776@telsasoft.com		7 years ago
..
backend	Fix assorted bugs in pg_get_partition_constraintdef().	7 years ago
bin	Implement %m in src/port/snprintf.c, and teach elog.c to rely on that.	7 years ago
common	Implement %m in src/port/snprintf.c, and teach elog.c to rely on that.	7 years ago
fe_utils	Fix lexing of standard multi-character operators in edge cases.	7 years ago
include	Fix assorted bugs in pg_get_partition_constraintdef().	7 years ago
interfaces	Build src/port files as a library with -fPIC, and use that in libpq.	7 years ago
makefiles	Refactor installation of extension headers.	7 years ago
pl	Clean up *printf macros to avoid conflict with format archetypes.	7 years ago
port	Build src/port files as a library with -fPIC, and use that in libpq.	7 years ago
template	Make some fixes to allow building Postgres on macOS 10.14 ("Mojave").	7 years ago
test	Fix assorted bugs in pg_get_partition_constraintdef().	7 years ago
timezone	Update time zone data files to tzdata release 2018e.	7 years ago
tools	Convert elog.c's useful_strerror() into a globally-used strerror wrapper.	7 years ago
tutorial	Deduplicate "invalid input syntax" messages for various types.	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Fix partial-build problems introduced by having more generated headers.	7 years ago
Makefile.global.in	Make some fixes to allow building Postgres on macOS 10.14 ("Mojave").	7 years ago
Makefile.shlib	Use -Bsymbolic for shared libraries on HP-UX and Solaris.	7 years ago
nls-global.mk	…