You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane f25d0619c7 Fix mishandling of equivalence-class tests in parameterized plans. ... Given a three-or-more-way equivalence class, such as X.Y = Y.Y = Z.Z, it was possible for the planner to omit one of the quals needed to enforce that all members of the equivalence class are actually equal. This only happened in the case of a parameterized join node for two of the relations, that is a plan tree like Nested Loop -> Scan X -> Nested Loop -> Scan Y -> Scan Z Filter: Z.Z = X.X The eclass machinery normally expects to apply X.X = Y.Y when those two relations are joined, but in this shape of plan tree they aren't joined until the top node --- and, if the lower nested loop is marked as parameterized by X, the top node will assume that the relevant eclass condition(s) got pushed down into the lower node. On the other hand, the scan of Z assumes that it's only responsible for constraining Z.Z to match any one of the other eclass members. So one or another of the required quals sometimes fell between the cracks, depending on whether consideration of the eclass in get_joinrel_parampathinfo() for the lower nested loop chanced to generate X.X = Y.Y or X.X = Z.Z as the appropriate constraint there. If it generated the latter, it'd erroneously suppose that the Z scan would take care of matters. To fix, force X.X = Y.Y to be generated and applied at that join node when this case occurs. This is *extremely* hard to hit in practice, because various planner behaviors conspire to mask the problem; starting with the fact that the planner doesn't really like to generate a parameterized plan of the above shape. (It might have been impossible to hit it before we tweaked things to allow this plan shape for star-schema cases.) Many thanks to Alexander Kirkouski for submitting a reproducible test case. The bug can be demonstrated in all branches back to 9.2 where parameterized paths were introduced, so back-patch that far.		10 years ago
..
clauses.h	Improve qual pushdown for RLS and SB views	11 years ago
cost.h	Redesign tablesample method API, and do extensive code review.	11 years ago
geqo.h	Update copyright for 2015	11 years ago
geqo_copy.h	Update copyright for 2015	11 years ago
geqo_gene.h	Update copyright for 2015	11 years ago
geqo_misc.h	Update copyright for 2015	11 years ago
geqo_mutation.h	Update copyright for 2015	11 years ago
geqo_pool.h	Update copyright for 2015	11 years ago
geqo_random.h	Update copyright for 2015	11 years ago
geqo_recombination.h	Update copyright for 2015	11 years ago
geqo_selection.h	Update copyright for 2015	11 years ago
joininfo.h	Update copyright for 2015	11 years ago
orclauses.h	Update copyright for 2015	11 years ago
pathnode.h	Still more fixes for planner's handling of LATERAL references.	10 years ago
paths.h	Fix mishandling of equivalence-class tests in parameterized plans.	10 years ago
placeholder.h	Update copyright for 2015	11 years ago
plancat.h	Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.	11 years ago
planmain.h	Allow foreign and custom joins to handle EvalPlanQual rechecks.	10 years ago
planner.h	Allow foreign tables to participate in inheritance.	11 years ago
predtest.h	Update copyright for 2015	11 years ago
prep.h	pgindent run for 9.5	11 years ago
restrictinfo.h	Update copyright for 2015	11 years ago
subselect.h	Update copyright for 2015	11 years ago
tlist.h	pgindent run for 9.5	11 years ago
var.h	Update copyright for 2015	11 years ago