You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane ff3c16d1e7 Fix code for re-finding scan position in a multicolumn GIN index. ... collectMatchBitmap() needs to re-find the index tuple it was previously looking at, after transiently dropping lock on the index page it's on. The tuple should still exist and be at its prior position or somewhere to the right of that, since ginvacuum never removes tuples but concurrent insertions could add one. However, there was a thinko in that logic, to the effect of expecting any inserted tuples to have the same index "attnum" as what we'd been scanning. Since there's no physical separation of tuples with different attnums, it's not terribly hard to devise scenarios where this fails, leading to transient "lost saved point in index" errors. (While I've duplicated this with manual testing, it seems impossible to make a reproducible test case with our available testing technology.) Fix by just continuing the scan when the attnum doesn't match. While here, improve the error message used if we do fail, so that it matches the wording used in btree for a similar case. collectMatchBitmap()'s posting-tree code path was previously not exercised at all by our regression tests. While I can't make a regression test that exhibits the bug, I can at least improve the code coverage here, so do that. The test case I made for this is an extension of one added by 4b754d6c1, so it only works in HEAD and v13; didn't seem worth trying hard to back-patch it. Per bug #16595 from Jesse Kinkead. This has been broken since multicolumn capability was added to GIN (commit 27cb66fdf), so back-patch to all supported branches. Discussion: https://postgr.es/m/16595-633118be8eef9ce2@postgresql.org		6 years ago
..
backend	Fix code for re-finding scan position in a multicolumn GIN index.	6 years ago
bin	Avoid non-constant format string argument to fprintf().	6 years ago
common	Fix command-line colorization on Windows with VT100-compatible environments	6 years ago
fe_utils	Fix parallel restore of FKs to partitioned tables	7 years ago
include	Fix handling of CREATE TABLE LIKE with inheritance.	6 years ago
interfaces	Stamp 12.4.	6 years ago
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	7 years ago
pl	Translation updates	6 years ago
port	Stamp 12.4.	6 years ago
template	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	7 years ago
test	Avoid pushing quals down into sub-queries that have grouping sets.	6 years ago
timezone	Ensure that distributed timezone abbreviation files are plain ASCII.	6 years ago
tools	Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.	6 years ago
tutorial	Phase 2 pgindent run for v12.	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Fix partial-build problems introduced by having more generated headers.	8 years ago
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	7 years ago
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	8 years ago
nls-global.mk	NLS: Fix backend gettext triggers	7 years ago