You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane b2e1eaa4a1 Fix transient clobbering of shared buffers during WAL replay. ... RestoreBkpBlocks was in the habit of zeroing and refilling the target buffer; which was perfectly safe when the code was written, but is unsafe during Hot Standby operation. The reason is that we have coding rules that allow backends to continue accessing a tuple in a heap relation while holding only a pin on its buffer. Such a backend could see transiently zeroed data, if WAL replay had occasion to change other data on the page. This has been shown to be the cause of bug #6425 from Duncan Rance (who deserves kudos for developing a sufficiently-reproducible test case) as well as Bridget Frey's re-report of bug #6200. It most likely explains the original report as well, though we don't yet have confirmation of that. To fix, change the code so that only bytes that are supposed to change will change, even transiently. This actually saves cycles in RestoreBkpBlocks, since it's not writing the same bytes twice. Also fix seq_redo, which has the same disease, though it has to work a bit harder to meet the requirement. So far as I can tell, no other WAL replay routines have this type of bug. In particular, the index-related replay routines, which would certainly be broken if they had to meet the same standard, are not at risk because we do not have coding rules that allow access to an index page when not holding a buffer lock on it. Back-patch to 9.0 where Hot Standby was added.		14 years ago
..
backend	Fix transient clobbering of shared buffers during WAL replay.	14 years ago
bin	Fix pg_restore's direct-to-database mode for INSERT-style table data.	14 years ago
include	Resolve timing issue with logging locks for Hot Standby.	14 years ago
interfaces	In ecpg removed old leftover check for given connection name.	14 years ago
makefiles	Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.	15 years ago
pl	Improve efficiency of recent changes to plperl's sv2cstr().	14 years ago
port	Stamp 9.1.2.	14 years ago
template	…
test	Fix pushing of index-expression qualifications through UNION ALL.	14 years ago
timezone	Update time zone data files to tzdata release 2011n.	14 years ago
tools	Fix MSVC builds broken by xsubpp change	14 years ago
tutorial	Stamp copyrights for year 2011.	15 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Fix some oversights in distprep and maintainer-clean targets.	15 years ago
Makefile.global.in	Make distprep and *clean build targets recurse into all subdirectories.	15 years ago
Makefile.shlib	Use single quotes in preference to double quotes for protecting pathnames.	15 years ago
bcc32.mak	Remove useless whitespace at end of lines	15 years ago
nls-global.mk	Fix makefile logic to not break the build when xgettext is missing	15 years ago
win32.mak	Remove useless whitespace at end of lines	15 years ago