You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Heikki Linnakangas b70c2143bb Move a few ResourceOwnerEnlarge() calls for safety and clarity. ... These are functions where a lot of things happen between the ResourceOwnerEnlarge and ResourceOwnerRemember calls. It's important that there are no unrelated ResourceOwnerRemember calls in the code in between, otherwise the reserved entry might be used up by the intervening ResourceOwnerRemember and not be available at the intended ResourceOwnerRemember call anymore. I don't see any bugs here, but the longer the code path between the calls is, the harder it is to verify. In bufmgr.c, there is a function similar to ResourceOwnerEnlarge, ReservePrivateRefCountEntry(), to ensure that the private refcount array has enough space. The ReservePrivateRefCountEntry() calls were made at different places than the ResourceOwnerEnlargeBuffers() calls. Move the ResourceOwnerEnlargeBuffers() and ReservePrivateRefCountEntry() calls together for consistency. Reviewed-by: Aleksander Alekseev, Michael Paquier, Julien Rouhaud Reviewed-by: Kyotaro Horiguchi, Hayato Kuroda, Álvaro Herrera, Zhihong Yu Reviewed-by: Peter Eisentraut, Andres Freund Discussion: https://www.postgresql.org/message-id/cbfabeb0-cd3c-e951-a572-19b365ed314d%40iki.fi		2 years ago
..
backend	Move a few ResourceOwnerEnlarge() calls for safety and clarity.	2 years ago
bin	Fix the test 003_logical_slots.	2 years ago
common	Remove distprep	2 years ago
fe_utils	Remove distprep	2 years ago
include	Stop including parsenodes.h in plannodes.h	2 years ago
interfaces	Remove distprep	2 years ago
makefiles	Remove distprep	2 years ago
pl	Remove distprep	2 years ago
port	Remove distprep	2 years ago
template	Use unnamed POSIX semaphores on Cygwin.	3 years ago
test	Don't install ldap_password_func in meson	2 years ago
timezone	Remove distprep	2 years ago
tools	Remove distprep	2 years ago
tutorial	Pre-beta mechanical code beautification.	3 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Remove distprep	2 years ago
Makefile.global.in	Remove distprep	2 years ago
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2 years ago
meson.build	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
nls-global.mk	Remove distprep	2 years ago