You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane b23b0f5588 Code review for recent changes in relcache.c. ... rd_replidindex should be managed the same as rd_oidindex, and rd_keyattr and rd_idattr should be managed like rd_indexattr. Omissions in this area meant that the bitmapsets computed for rd_keyattr and rd_idattr would be leaked during any relcache flush, resulting in a slow but permanent leak in CacheMemoryContext. There was also a tiny probability of relcache entry corruption if we ran out of memory at just the wrong point in RelationGetIndexAttrBitmap. Otherwise, the fields were not zeroed where expected, which would not bother the code any AFAICS but could greatly confuse anyone examining the relcache entry while debugging. Also, create an API function RelationGetReplicaIndex rather than letting non-relcache code be intimate with the mechanisms underlying caching of that value (we won't even mention the memory leak there). Also, fix a relcache flush hazard identified by Andres Freund: RelationGetIndexAttrBitmap must not assume that rd_replidindex stays valid across index_open. The aspects of this involving rd_keyattr date back to 9.3, so back-patch those changes.		12 years ago
..
backend	Code review for recent changes in relcache.c.	12 years ago
bin	Make initdb throw error for bad locale values.	12 years ago
common	pgindent run for 9.4	12 years ago
include	Code review for recent changes in relcache.c.	12 years ago
interfaces	Fix missing dependencies in ecpg's test Makefiles.	12 years ago
makefiles	Flush a stray definition of $(DLLTOOL).	12 years ago
pl	pgindent run for 9.4	12 years ago
port	pgindent run for 9.4	12 years ago
template	Revert to using --enable-auto-import in Cygwin builds.	12 years ago
test	Be more wary in choice of timezone names to test make_timestamptz with.	12 years ago
timezone	pgindent run for 9.4	12 years ago
tools	Add Valgrind suppression for reorderbuffer padding bytes.	12 years ago
tutorial	pgindent run for 9.4	12 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	build: add EXTRA_REGRESS_OPTS to all pg_regress invocations	12 years ago
Makefile.shlib	Tweak position of $(DLL_DEFFILE) in shared-library link commands.	12 years ago
bcc32.mak	…
nls-global.mk	Setup error context callback for transaction lock waits	12 years ago
win32.mak	…