You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane bc6374cd76 Change IndexAmRoutines to be statically-allocated structs. ... Up to now, index amhandlers were expected to produce a new, palloc'd struct on each call. That requires palloc/pfree overhead, and creates a risk of memory leaks if the caller fails to pfree, and the time taken to fill such a large structure isn't nil. Moreover, we were storing these things in the relcache, eating several hundred bytes for each cached index. There is not anything in these structs that needs to vary at runtime, so let's change the definition so that an amhandler can return a pointer to a "static const" struct of which there's only one copy per index AM. Mark all the core code's IndexAmRoutine pointers const so that we catch anyplace that might still try to change or pfree one. (This is similar to the way we were already handling TableAmRoutine structs. This commit does fix one comment that was infelicitously copied-and-pasted into tableamapi.c.) This commit needs to be called out in the v19 release notes as an API change for extension index AMs. An un-updated AM will still work (as of now, anyway) but it risks memory leaks and will be slower than necessary. Author: Matthias van de Meent <boekewurm+postgres@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAEoWx2=vApYk2LRu8R0DdahsPNEhWUxGBZ=rbZo1EXE=uA+opQ@mail.gmail.com		1 week ago
..
backend	Change IndexAmRoutines to be statically-allocated structs.	1 week ago
bin	Split some long Makefile lists	2 weeks ago
common	Use palloc_object() and palloc_array() in more areas of the tree	1 month ago
fe_utils	Add ParallelSlotSetIdle().	1 month ago
include	Change IndexAmRoutines to be statically-allocated structs.	1 week ago
interfaces	Split some long Makefile lists	2 weeks ago
makefiles	Fix meson warning due to missing declaration of NM	1 month ago
pl	Split some long Makefile lists	2 weeks ago
port	Fix another case of indirectly casting away const.	2 weeks ago
template	…
test	Change IndexAmRoutines to be statically-allocated structs.	1 week ago
timezone	Use palloc_object() and palloc_array() in more areas of the tree	1 month ago
tools	Remove MsgType type	2 weeks ago
tutorial	Use palloc_object() and palloc_array() in more areas of the tree	1 month ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	libpq: Refactor logic checking for exit() in shared library builds	1 month ago
Makefile.shlib	…
meson.build	…
nls-global.mk	Fix update-po for the PGXS case	3 months ago