You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 8a7f24b22f Repair bogus EPQ plans generated for postgres_fdw foreign joins. ... postgres_fdw's postgresGetForeignPlan() assumes without checking that the outer_plan it's given for a join relation must have a NestLoop, MergeJoin, or HashJoin node at the top. That's been wrong at least since commit 4bbf6edfb (which could cause insertion of a Sort node on top) and it seems like a pretty unsafe thing to Just Assume even without that. Through blind good fortune, this doesn't seem to have any worse consequences today than strange EXPLAIN output, but it's clearly trouble waiting to happen. To fix, test the node type explicitly before touching Join-specific fields, and avoid jamming the new tlist into a node type that can't do projection. Export a new support function from createplan.c to avoid building low-level knowledge about the latter into FDWs. Back-patch to 9.6 where the faulty coding was added. Note that the associated regression test cases don't show any changes before v11, apparently because the tests back-patched with 4bbf6edfb don't actually exercise the problem case before then (there's no top-level Sort in those plans). Discussion: https://postgr.es/m/8946.1544644803@sss.pgh.pa.us		7 years ago
..
expected	Fix hashjoin costing mistake introduced with inner_unique optimization.	8 years ago
sql	Fix test case for 'outer pathkeys do not match mergeclauses' fix.	8 years ago
.gitignore	Add postgres_fdw contrib module.	13 years ago
Makefile	Prevent accidental linking of system-supplied copies of libpq.so etc.	8 years ago
connection.c	Re-establish postgres_fdw connections after server or user mapping changes.	9 years ago
deparse.c	Fix postgres_fdw to cope with duplicate GROUP BY entries.	8 years ago
option.c	Phase 3 of pgindent updates.	9 years ago
postgres_fdw--1.0.sql	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.c	Repair bogus EPQ plans generated for postgres_fdw foreign joins.	7 years ago
postgres_fdw.control	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.h	postgres_fdw: Move function prototype to correct section.	9 years ago
shippable.c	Update copyright via script for 2017	9 years ago