You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane ab4ff2889d Fix memory leak in repeated GIN index searches. ... Commit d88976cfa1 removed this code from ginFreeScanKeys(): - if (entry->list) - pfree(entry->list); evidently in the belief that that ItemPointer array is allocated in the keyCtx and so would be reclaimed by the following MemoryContextReset. Unfortunately, it isn't and it won't. It'd likely be a good idea for that to become so, but as a simple and back-patchable fix in the meantime, restore this code to ginFreeScanKeys(). Also, add a similar pfree to where startScanEntry() is about to zero out entry->list. I am not sure if there are any code paths where this change prevents a leak today, but it seems like cheap future-proofing. In passing, make the initial allocation of so->entries[] use palloc not palloc0. The code doesn't depend on unused entries being zero; if it did, the array-enlargement code in ginFillScanEntry() would be wrong. So using palloc0 initially can only serve to confuse readers about what the invariant is. Per report from Felipe de Jesús Molina Bravo, via Jaime Casanova in <CAJGNTeMR1ndMU2Thpr8GPDUfiHTV7idELJRFusA5UXUGY1y-eA@mail.gmail.com>		10 years ago
..
backend	Fix memory leak in repeated GIN index searches.	10 years ago
bin	Fix order of MemSet arguments	10 years ago
common	Make get_controlfile() error logging consistent with src/common	10 years ago
include	Widen query numbers-of-tuples-processed counters to uint64.	10 years ago
interfaces	Handle invalid libpq sockets in more places	10 years ago
makefiles	Fix typos in comments and doc	10 years ago
pl	Widen query numbers-of-tuples-processed counters to uint64.	10 years ago
port	Suppress GCC 6 warning about self-comparison	10 years ago
template	Remove some remains from Alpha support removal	10 years ago
test	Fix whitespace and remove obsolete gitattributes entry	10 years ago
timezone	Update time zone data files to tzdata release 2016a.	10 years ago
tools	Checkpoint sorting and balancing.	10 years ago
tutorial	Update copyright for 2016	10 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Respect TEMP_CONFIG when pg_regress_check and friends are called	10 years ago
Makefile.shlib	AIX: Link TRANSFORM modules with their dependencies.	11 years ago
bcc32.mak	…
nls-global.mk	…
win32.mak	…