You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Heikki Linnakangas 555276f859 Fix resource leak when a FDW's ForeignAsyncRequest function fails ... If an error is thrown after calling CreateWaitEventSet(), the memory of a WaitEventSet is free'd as it's allocated in the short-lived memory context, but the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that it contains are leaked. Use PG_TRY-FINALLY to ensure it gets freed. (On master, I will apply a better fix, using ResourceOwners to track the WaitEventSet, but that's not backpatchable.) The added test doesn't check for leaking resources, so it passed even before this commit. But at least it covers the code path. In the passing, fix misleading comment on what the 'nevents' argument to WaitEventSetWait means. Report by Alexander Lakhin, analysis and suggestion for the fix by Tom Lane. Fixes bug #17828. Backpatch to v14 where async execution was introduced, but master gets a different fix. Discussion: https://www.postgresql.org/message-id/17828-122da8cba23236be@postgresql.org Discussion: https://www.postgresql.org/message-id/472235.1678387869@sss.pgh.pa.us		2 years ago
..
expected	Fix resource leak when a FDW's ForeignAsyncRequest function fails	2 years ago
sql	Fix resource leak when a FDW's ForeignAsyncRequest function fails	2 years ago
.gitignore	Add postgres_fdw contrib module.	13 years ago
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	postgres_fdw: Fix subabort cleanup of connections used in asynchronous execution.	4 years ago
deparse.c	Fix postgres_fdw to check shippability of sort clauses properly.	4 years ago
option.c	Avoid using ambiguous word "non-negative" in error messages.	4 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	5 years ago
postgres_fdw--1.0.sql	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.c	Fix calculation of which GENERATED columns need to be updated.	3 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Fix postgres_fdw to check shippability of sort clauses properly.	4 years ago
shippable.c	Replace remaining uses of "whitelist".	5 years ago