You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 377c25d322 Fix overread in JSON parsing errors for incomplete byte sequences ... json_lex_string() relies on pg_encoding_mblen_bounded() to point to the end of a JSON string when generating an error message, and the input it uses is not guaranteed to be null-terminated. It was possible to walk off the end of the input buffer by a few bytes when the last bytes consist of an incomplete multi-byte sequence, as token_terminator would point to a location defined by pg_encoding_mblen_bounded() rather than the end of the input. This commit switches token_terminator so as the error uses data up to the end of the JSON input. More work should be done so as this code could rely on an equivalent of report_invalid_encoding() so as incorrect byte sequences can show in error messages in a readable form. This requires work for at least two cases in the JSON parsing API: an incomplete token and an invalid escape sequence. A more complete solution may be too invasive for a backpatch, so this is left as a future improvement, taking care of the overread first. A test is added on HEAD as test_json_parser makes this issue straight-forward to check. Note that pg_encoding_mblen_bounded() no longer has any callers. This will be removed on HEAD with a separate commit, as this is proving to encourage unsafe coding. Author: Jacob Champion Discussion: https://postgr.es/m/CAOYmi+ncM7pwLS3AnKCSmoqqtpjvA8wmCdoBtKA3ZrB2hZG6zA@mail.gmail.com Backpatch-through: 13		1 year ago
..
unicode	Initial pgindent and pgperltidy run for v13.	5 years ago
.gitignore	Replace the data structure used for keyword lookup.	7 years ago
Makefile	Move frontend-side archive APIs from src/common/ to src/fe_utils/	5 years ago
archive.c	Move routine building restore_command to src/common/	6 years ago
base64.c	Update copyrights for 2020	6 years ago
checksum_helper.c	Add checksum helper functions.	6 years ago
config_info.c	Simplify passing of configure arguments to pg_config	6 years ago
controldata_utils.c	Try to handle torn reads of pg_control in frontend.	2 years ago
d2s.c	Update copyrights for 2020	6 years ago
d2s_full_table.h	Update copyrights for 2020	6 years ago
d2s_intrinsics.h	Update copyrights for 2020	6 years ago
digit_table.h	Change floating-point output format for improved performance.	7 years ago
encnames.c	Rationalize code placement between wchar.c, encnames.c, and mbutils.c.	6 years ago
exec.c	Make EXEC_BACKEND more convenient on Linux and FreeBSD.	3 years ago
f2s.c	Update copyrights for 2020	6 years ago
fe_memutils.c	Update copyrights for 2020	6 years ago
file_perm.c	Update copyrights for 2020	6 years ago
file_utils.c	Change client-side fsync_fname() to report errors fatally	6 years ago
hashfn.c	Dial back -Wimplicit-fallthrough to level 3	5 years ago
ip.c	Update copyrights for 2020	6 years ago
jsonapi.c	Fix overread in JSON parsing errors for incomplete byte sequences	1 year ago
keywords.c	Update copyrights for 2020	6 years ago
kwlookup.c	Update copyrights for 2020	6 years ago
link-canary.c	Update copyrights for 2020	6 years ago
logging.c	Fix command-line colorization on Windows with VT100-compatible environments	6 years ago
md5.c	Update copyrights for 2020	6 years ago
pg_lzcompress.c	Improve pglz_decompress's defenses against corrupt compressed data.	2 years ago
pgfnames.c	Update copyrights for 2020	6 years ago
protocol_openssl.c	Move OpenSSL routines for min/max protocol setting to src/common/	6 years ago
psprintf.c	Update copyrights for 2020	6 years ago
relpath.c	Add declaration-level assertions for compile-time checks	6 years ago
restricted_token.c	Improve error messages after LoadLibrary()	5 years ago
rmtree.c	Update copyrights for 2020	6 years ago
ryu_common.h	Update copyrights for 2020	6 years ago
saslprep.c	Add support for other normal forms to Unicode normalization API	6 years ago
scram-common.c	Initial pgindent and pgperltidy run for v13.	5 years ago
sha2.c	Update copyrights for 2020	6 years ago
sha2_openssl.c	Update copyrights for 2020	6 years ago
string.c	Update copyrights for 2020	6 years ago
stringinfo.c	Update copyrights for 2020	6 years ago
unicode_norm.c	Fix buffer overrun in unicode string normalization with empty input	4 years ago
username.c	Update copyrights for 2020	6 years ago
wait_error.c	Update copyrights for 2020	6 years ago
wchar.c	Fix incautious handling of possibly-miscoded strings in client code.	4 years ago