You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane cb5c14984a Fix misestimation of n_distinct for a nearly-unique column with many nulls. ... If ANALYZE found no repeated non-null entries in its sample, it set the column's stadistinct value to -1.0, intending to indicate that the entries are all distinct. But what this value actually means is that the number of distinct values is 100% of the table's rowcount, and thus it was overestimating the number of distinct values by however many nulls there are. This could lead to very poor selectivity estimates, as for example in a recent report from Andreas Joseph Krogh. We should discount the stadistinct value by whatever we've estimated the nulls fraction to be. (That is what will happen if we choose to use a negative stadistinct for a column that does have repeated entries, so this code path was just inconsistent.) In addition to fixing the stadistinct entries stored by several different ANALYZE code paths, adjust the logic where get_variable_numdistinct() forces an "all distinct" estimate on the basis of finding a relevant unique index. Unique indexes don't reject nulls, so there's no reason to assume that the null fraction doesn't apply. Back-patch to all supported branches. Back-patching is a bit of a judgment call, but this problem seems to affect only a few users (else we'd have identified it long ago), and it's bad enough when it does happen that destabilizing plan choices in a worse direction seems unlikely. Patch by me, with documentation wording suggested by Dean Rasheed Report: <VisenaEmail.26.df42f82acae38a58.156463942b8@tc7-visena> Discussion: <16143.1470350371@sss.pgh.pa.us>		10 years ago
..
backend	Fix misestimation of n_distinct for a nearly-unique column with many nulls.	10 years ago
bin	Fix pg_dump's handling of public schema with both -c and -C options.	10 years ago
common	…
include	Fix misestimation of n_distinct for a nearly-unique column with many nulls.	10 years ago
interfaces	Teach libpq to decode server version correctly from future servers.	10 years ago
makefiles	Link $(WIN32RES) into single-file modules only when PGFILEDESC is set.	11 years ago
pl	Make pltcl regression tests safe for Danish locale.	10 years ago
port	Stamp 9.5.3.	10 years ago
template	…
test	Don't CHECK_FOR_INTERRUPTS between WaitLatch and ResetLatch.	10 years ago
timezone	Update time zone data files to tzdata release 2016f.	10 years ago
tools	Fix MSVC build for changes in zic.	10 years ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Back-patch fixes to make TAP tests work on Windows.	10 years ago
Makefile.shlib	Make the AIX case of Makefile.shlib safe for parallel make.	10 years ago
bcc32.mak	…
nls-global.mk	nls-global.mk: search build dir for source files, too	10 years ago
win32.mak	…