You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane ca70bdaefe Fix issues around strictness of SIMILAR TO. ... As a result of some long-ago quick hacks, the SIMILAR TO operator and the corresponding flavor of substring() interpreted "ESCAPE NULL" as selecting the default escape character '\'. This is both surprising and not per spec: the standard is clear that these functions should return NULL for NULL input. Additionally, because of inconsistency of the strictness markings of 3-argument substring() and similar_escape(), the planner could not inline the SQL definition of substring(), resulting in a substantial performance penalty compared to the underlying POSIX substring() function. The simplest fix for this would be to change the strictness marking of similar_escape(), but if we do that we risk breaking existing views that depend on that function. Hence, leave similar_escape() as-is as a compatibility function, and instead invent a new function similar_to_escape() that comes in two strict variants. There are a couple of other behaviors in this area that are also not per spec, but they are documented and seem generally at least as sane as the spec's definition, so leave them alone. But improve the documentation to describe them fully. Patch by me; thanks to Álvaro Herrera and Andrew Gierth for review and discussion. Discussion: https://postgr.es/m/14047.1557708214@sss.pgh.pa.us		6 years ago
..
backend	Fix issues around strictness of SIMILAR TO.	6 years ago
bin	Message style fixes	6 years ago
common	Refactor logic to remove trailing CR/LF characters from strings	6 years ago
fe_utils	Fix memory leak coming from simple lists built in reindexdb	7 years ago
include	Fix issues around strictness of SIMILAR TO.	6 years ago
interfaces	Message style fixes	6 years ago
makefiles	Remove support for non-ELF BSD systems	7 years ago
pl	Split tuptoaster.c into three separate files.	6 years ago
port	Use explicit_bzero	6 years ago
template	Yet further rethinking of build changes for macOS Mojave.	7 years ago
test	Fix issues around strictness of SIMILAR TO.	6 years ago
timezone	Use zic's new "-b slim" option to generate smaller timezone files.	6 years ago
tools	Create an API for inserting and deleting rows in TOAST tables.	6 years ago
tutorial	Phase 2 pgindent run for v12.	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Fix partial-build problems introduced by having more generated headers.	8 years ago
Makefile.global.in	Fix inconsistencies and typos in the tree	7 years ago
Makefile.shlib	Remove support for non-ELF BSD systems	7 years ago
nls-global.mk	Move logging.h and logging.c from src/fe_utils/ to src/common/.	7 years ago