You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane cd69ec66c8 Improve psql's tab completion for filenames. ... The Readline library contains a fair amount of knowledge about how to tab-complete filenames, but it turns out that that doesn't work too well unless we follow its expectation that we use its filename quoting hooks to quote and de-quote filenames. We were trying to do such quote handling within complete_from_files(), and that's still what we have to do if we're using libedit, which lacks those hooks. But for Readline, it works a lot better if we tell Readline that single-quote is a quoting character and then provide hooks that know the details of the quoting rules for SQL and psql meta-commands. Hence, resurrect the quoting hook functions that existed in the original version of tab-complete.c (and were disabled by commit f6689a328 because they "didn't work so well yet"), and whack on them until they do seem to work well. Notably, this fixes bug #16059 from Steven Winfield, who pointed out that the previous coding would strip quote marks from filenames in SQL COPY commands, even though they're syntactically necessary there. Now, we not only don't do that, but we'll add a quote mark when you tab-complete, even if you didn't type one. Getting this to work across a range of libedit versions (and, to a lesser extent, libreadline versions) was depressingly difficult. It will be interesting to see whether the new regression test cases pass everywhere in the buildfarm. Some future patch might try to handle quoted SQL identifiers with similar explicit quoting/dequoting logic, but that's for another day. Patch by me, reviewed by Peter Eisentraut. Discussion: https://postgr.es/m/16059-8836946734c02b84@postgresql.org		6 years ago
..
Makefile	Install our "missing" script where PGXS builds can find it.	10 years ago
ac_func_accept_argtypes.m4	Reorder configure tests for accept() in Windows	6 years ago
ax_prog_perl_modules.m4	Make configure check for IPC::Run when --enable-tap-tests is specified.	8 years ago
ax_pthread.m4	Update config/ax_pthread.m4 to latest upstream version.	7 years ago
c-compiler.m4	Make use of compiler builtins and/or assembly for CLZ, CTZ, POPCNT.	6 years ago
c-library.m4	Simplify PGAC_STRUCT_TIMEZONE Autoconf macro	6 years ago
check_decls.m4	Fix configure's AC_CHECK_DECLS tests to work correctly with clang.	7 years ago
config.guess	Update config.guess and config.sub	6 years ago
config.sub	Update config.guess and config.sub	6 years ago
docbook.m4	Convert documentation to DocBook XML	8 years ago
general.m4	Remove useless whitespace at end of lines	15 years ago
install-sh	Fix install-strip on Mac OS X	13 years ago
libtool.m4	Rename AC_PROG_LD* macros to PGAC_PROG_LD*. This avoids clashes with the	21 years ago
llvm.m4	Use better comment marker in Autoconf input	6 years ago
missing	Remove cvs keywords from all files.	15 years ago
perl.m4	configure: More use of AC_ARG_VAR	7 years ago
pkg.m4	ICU support	8 years ago
prep_buildtree	Fix vpath build	6 years ago
programs.m4	Improve psql's tab completion for filenames.	6 years ago
python.m4	Remove support for Python older than 2.6	6 years ago
tcl.m4	configure: More use of AC_ARG_VAR	7 years ago