You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 4a07c09613 Fix memory leakage in postgres_fdw's DirectModify code path. ... postgres_fdw tries to use PG_TRY blocks to ensure that it will eventually free the PGresult created by the remote modify command. However, it's fundamentally impossible for this scheme to work reliably when there's RETURNING data, because the query could fail in between invocations of postgres_fdw's DirectModify methods. There is at least one instance of exactly this situation in the regression tests, and the ensuing session-lifespan leak is visible under Valgrind. We can improve matters by using a memory context reset callback attached to the ExecutorState context. That ensures that the PGresult will be freed when the ExecutorState context is torn down, even if control never reaches postgresEndDirectModify. I have little faith that there aren't other potential PGresult leakages in the backend modules that use libpq. So I think it'd be a good idea to apply this concept universally by creating infrastructure that attaches a reset callback to every PGresult generated in the backend. However, that seems too invasive for v18 at this point, let alone the back branches. So for the moment, apply this narrow fix that just makes DirectModify safe. I have a patch in the queue for the more general idea, but it will have to wait for v19. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/2976982.1748049023@sss.pgh.pa.us Backpatch-through: 13		4 months ago
..
expected	Handle default NULL insertion a little better.	8 months ago
sql	Restrict accesses to non-system views and foreign tables during pg_dump.	1 year ago
.gitignore	Add postgres_fdw contrib module.	13 years ago
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	Make postgres_fdw request remote time zone 'GMT' not 'UTC'.	1 year ago
deparse.c	Fix deparsing of Consts in postgres_fdw ORDER BY	2 years ago
option.c	Avoid using ambiguous word "non-negative" in error messages.	4 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	5 years ago
postgres_fdw--1.0.sql	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.c	Fix memory leakage in postgres_fdw's DirectModify code path.	4 months ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Fix postgres_fdw to check shippability of sort clauses properly.	4 years ago
shippable.c	Replace remaining uses of "whitelist".	5 years ago