You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Geoghegan d004147eb3 Fix nbtree metapage cache upgrade bug. ... Commit 857f9c36cd, which taught nbtree VACUUM to avoid unnecessary index scans, bumped the nbtree version number from 2 to 3, while adding the ability for nbtree indexes to be upgraded on-the-fly. Various assertions that assumed that an nbtree index was always on version 2 had to be changed to accept any supported version (version 2 or 3 on Postgres 11). However, a few assertions were missed in the initial commit, all of which were in code paths that cache a local copy of the metapage metadata, where the index had been expected to be on the current version (no longer version 2) as a generic sanity check. Rather than simply update the assertions, follow-up commit 0a64b45152 intentionally made the metapage caching code update the per-backend cached metadata version without changing the on-disk version at the same time. This could even happen when the planner needed to determine the height of a B-Tree for costing purposes. The assertions only fail on Postgres v12 when upgrading from v10, because they were adjusted to use the authoritative shared memory metapage by v12's commit dd299df8. To fix, remove the cache-only upgrade mechanism entirely, and update the assertions themselves to accept any supported version (go back to using the cached version in v12). The fix is almost a full revert of commit 0a64b45152 on the v11 branch. VACUUM only considers the authoritative metapage, and never bothers with a locally cached version, whereas everywhere else isn't interested in the metapage fields that were added by commit 857f9c36cd. It seems unlikely that this bug has affected any user on v11. Reported-By: Christoph Berg Bug: #15896 Discussion: https://postgr.es/m/15896-5b25e260fdb0b081%40postgresql.org Backpatch: 11-, where VACUUM was taught to avoid unnecessary index scans.		7 years ago
..
backend	Fix nbtree metapage cache upgrade bug.	7 years ago
bin	Fix inconsistencies and typos in the tree	7 years ago
common	Use consistent style for checking return from system calls	7 years ago
fe_utils	Use appendStringInfoString and appendPQExpBufferStr where possible	7 years ago
include	Fix nbtree metapage cache upgrade bug.	7 years ago
interfaces	Fix inconsistencies and typos in the tree	7 years ago
makefiles	Remove support for non-ELF BSD systems	7 years ago
pl	Represent Lists as expansible arrays, not chains of cons-cells.	7 years ago
port	Fix inconsistencies and typos in the tree	7 years ago
template	…
test	Fix handling of NULLs in MCV items and constants	7 years ago
timezone	Update time zone data files to tzdata release 2019b.	7 years ago
tools	Fix some inconsistencies in MSVC scripts	7 years ago
tutorial	Phase 2 pgindent run for v12.	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Remove support for non-ELF BSD systems	7 years ago
Makefile.shlib	Remove support for non-ELF BSD systems	7 years ago
nls-global.mk	Move logging.h and logging.c from src/fe_utils/ to src/common/.	7 years ago