You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane d376ab570e In ExecInitModifyTable, don't scribble on the source plan. ... The code carelessly modified mtstate->ps.plan->targetlist, which it's not supposed to do. Fortunately, there's not really any need to do that because the planner already set up a perfectly acceptable targetlist for the plan node. We just need to remove the erroneous assignments and update some relevant comments. As it happens, the erroneous assignments caused the targetlist to point to a different part of the source plan tree, so that there isn't really a risk of the pointer becoming dangling after executor termination. The only visible effect of this change we can find is that EXPLAIN will show upper references to the ModifyTable's output expressions using different variables. Formerly it showed Vars from the first target relation that survived executor-startup pruning. Now it always shows such references using the first relation appearing in the planner output, independently of what happens during executor pruning. On the whole that seems like a good thing. Also make a small tweak in ExplainPreScanNode to ensure that the first relation will receive a refname assignment in set_rtable_names, even if it got pruned at startup. Previously the Vars might be shown without any table qualification, which is confusing in a multi-table query. I considered back-patching this, but since the bug doesn't seem to have any really terrible consequences in existing branches, it seems better to not change their EXPLAIN output. It's not too late for v18 though, especially since v18 already made other changes in the EXPLAIN output for these cases. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Author: Andres Freund <andres@anarazel.de> Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/213261.1747611093@sss.pgh.pa.us		7 months ago
..
backend	In ExecInitModifyTable, don't scribble on the source plan.	7 months ago
bin	pg_dump: Adjust reltuples from 0 to -1 for dumps of older versions.	7 months ago
common	Use 'void *' for arbitrary buffers, 'uint8 *' for byte arrays	8 months ago
fe_utils	Fix incorrect format placeholders	8 months ago
include	Revert "Don't lock partitions pruned by initial pruning"	7 months ago
interfaces	ecpg: Add missing newline in meson.build	7 months ago
makefiles	oauth: Move the builtin flow into a separate module	8 months ago
pl	Translation updates	8 months ago
port	Fix incorrect year in some copyright notices	7 months ago
template	thread-safety: gmtime_r(), localtime_r()	1 year ago
test	In ExecInitModifyTable, don't scribble on the source plan.	7 months ago
timezone	Update time zone data files to tzdata release 2025b.	8 months ago
tools	Doc: add pre-branch task to run src/tools/copyright.pl.	7 months ago
tutorial	Doc: simplify the tutorial's window-function examples.	11 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	oauth: Move the builtin flow into a separate module	8 months ago
Makefile.shlib	…
meson.build	Update copyright for 2025	1 year ago
nls-global.mk	…