You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane a5fc46414d Avoid making commutatively-duplicate clauses in EquivalenceClasses. ... When we decide we need to make a derived clause equating a.x and b.y, we already will re-use a previously-made clause "a.x = b.y". But we might instead have "b.y = a.x", which is perfectly usable because equivclass.c has never promised anything about the operand order in clauses it builds. Saving construction of a new RestrictInfo doesn't matter all that much in itself --- but because we cache selectivity estimates and so on per-RestrictInfo, there's a possibility of saving a fair amount of duplicative effort downstream. Hence, check for commutative matches as well as direct ones when seeing if we have a pre-existing clause. This changes the visible clause order in several regression test cases, but they're all clearly-insignificant changes. Checking for the reverse operand order is simple enough, but if we wanted to check for operator OID match we'd need to call get_commutator here, which is not so cheap. I concluded that we don't really need the operator check anyway, so I just removed it. It's unlikely that an opfamily contains more than one applicable operator for a given pair of operand datatypes; and if it does they had better give the same answers, so there seems little need to insist that we use exactly the one select_equality_operator chose. Using the current core regression suite as a test case, I see this change reducing the number of new join clauses built by create_join_clause from 9673 to 5142 (out of 26652 calls). So not quite 50% savings, but pretty close to it. Discussion: https://postgr.es/m/78062.1666735746@sss.pgh.pa.us		3 years ago
..
expected	Avoid making commutatively-duplicate clauses in EquivalenceClasses.	3 years ago
sql	Disallow MERGE cleanly for foreign partitions	3 years ago
.gitignore	Add postgres_fdw contrib module.	13 years ago
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	Rename SetSingleFuncCall() to InitMaterializedSRF()	3 years ago
deparse.c	Fix final warnings produced by -Wshadow=compatible-local	3 years ago
meson.build	meson: Add windows resource files	3 years ago
option.c	Adjust assorted hint messages that list all valid options.	3 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	4 years ago
postgres_fdw--1.0.sql	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.c	Fix confusion about havingQual vs hasHavingQual in planner.	3 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Harmonize parameter names in contrib code.	3 years ago
shippable.c	Update copyright for 2022	4 years ago