You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier d77f91214f Handle better implicit transaction state of pipeline mode ... When using a pipeline, a transaction starts from the first command and is committed with a Sync message or when the pipeline ends. Functions like IsInTransactionBlock() or PreventInTransactionBlock() were already able to understand a pipeline as being in a transaction block, but it was not the case of CheckTransactionBlock(). This function is called for example to generate a WARNING for SET LOCAL, complaining that it is used outside of a transaction block. The current state of the code caused multiple problems, like: - SET LOCAL executed at any stage of a pipeline issued a WARNING, even if the command was at least second in line where the pipeline is in a transaction state. - LOCK TABLE failed when invoked at any step of a pipeline, even if it should be able to work within a transaction block. The pipeline protocol assumes that the first command of a pipeline is not part of a transaction block, and that any follow-up commands is considered as within a transaction block. This commit changes the backend so as an implicit transaction block is started each time the first Execute message of a pipeline has finished processing, with this implicit transaction block ended once a sync is processed. The checks based on XACT_FLAGS_PIPELINING in the routines checking if we are in a transaction block are not necessary: it is enough to rely on the existing ones. Some tests are added to pgbench, that can be backpatched down to v17 when \syncpipeline is involved and down to v14 where \startpipeline and \endpipeline are available. This is unfortunately limited regarding the error patterns that can be checked, but it provides coverage for various pipeline combinations to check if these succeed or fail. These tests are able to capture the case of SET LOCAL's WARNING. The author has proposed a different feature to improve the coverage by adding similar meta-commands to psql where error messages could be checked, something more useful for the cases where commands cannot be used in transaction blocks, like REINDEX CONCURRENTLY or VACUUM. This is considered as future work for v18~. Author: Anthonin Bonnefoy Reviewed-by: Jelte Fennema-Nio, Michael Paquier Discussion: https://postgr.es/m/CAO6_XqrWO8uNBQrSu5r6jh+vTGi5Oiyk4y8yXDORdE2jbzw8xw@mail.gmail.com Backpatch-through: 13		1 year ago
..
backend	Handle better implicit transaction state of pipeline mode	1 year ago
bin	Handle better implicit transaction state of pipeline mode	1 year ago
common	Clean up newlines following left parentheses	1 year ago
fe_utils	Prevent mis-encoding of "trailing junk after numeric literal" errors.	1 year ago
include	Clean up newlines following left parentheses	1 year ago
interfaces	Translation updates	1 year ago
makefiles	Optimize pg_popcount() with AVX-512 instructions.	2 years ago
pl	Add support for Tcl 9	1 year ago
port	Fix overflow in bsearch_arg() with more than INT_MAX elements	1 year ago
template	Remove AIX support	2 years ago
test	Fix NULLIF()'s handling of read-write expanded objects.	1 year ago
timezone	Update time zone data files to tzdata release 2024b.	1 year ago
tools	Avoid deleting critical WAL segments during pg_rewind	1 year ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Update Unicode data to CLDR 45	2 years ago
Makefile.shlib	Remove AIX support	2 years ago
meson.build	…
nls-global.mk	…