You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 9a109452da Fix bugs in contrib/pg_visibility. ... collect_corrupt_items() failed to initialize tuple.t_self. While HeapTupleSatisfiesVacuum() doesn't actually use that value, it does Assert that it's valid, so that the code would dump core if ip_posid chanced to be zero. (That's somewhat unlikely, which probably explains how this got missed. In any case it wouldn't matter for field use.) Also, collect_corrupt_items was returning the wrong TIDs, that is the contents of t_ctid rather than the tuple's own location. This would be the same thing in simple cases, but it could be wrong if, for example, a past update attempt had been rolled back, leaving a live tuple whose t_ctid doesn't point at itself. Also, in pg_visibility(), guard against trying to read a page past the end of the rel. The VM code handles inquiries beyond the end of the map by silently returning zeroes, and it seems like we should do the same thing here. I ran into the assertion failure while using pg_visibility to check pg_upgrade's behavior, and then noted the other problems while reading the code. Report: <29043.1475288648@sss.pgh.pa.us>		9 years ago
..
Makefile	Add integrity-checking functions to pg_visibility.	9 years ago
pg_visibility--1.0--1.1.sql	pg_visibility: Add pg_truncate_visibility_map function.	9 years ago
pg_visibility--1.1.sql	pg_visibility: Add pg_truncate_visibility_map function.	9 years ago
pg_visibility.c	Fix bugs in contrib/pg_visibility.	9 years ago
pg_visibility.control	Add integrity-checking functions to pg_visibility.	9 years ago