You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Eisentraut dfa774ff9a Fix a crash in logical replication ... The bug was that determining which columns are part of the replica identity index using RelationGetIndexAttrBitmap() would run eval_const_expressions() on index expressions and predicates across all indexes of the table, which in turn might require a snapshot, but there wasn't one set, so it crashes. There were actually two separate bugs, one on the publisher and one on the subscriber. To trigger the bug, a table that is part of a publication or subscription needs to have an index with a predicate or expression that lends itself to constant expressions simplification. The fix is to avoid the constant expressions simplification in RelationGetIndexAttrBitmap(), so that it becomes safe to call in these contexts. The constant expressions simplification comes from the calls to RelationGetIndexExpressions()/RelationGetIndexPredicate() via BuildIndexInfo(). But RelationGetIndexAttrBitmap() calling BuildIndexInfo() is overkill. The latter just takes pg_index catalog information, packs it into the IndexInfo structure, which former then just unpacks again and throws away. We can just do this directly with less overhead and skip the troublesome calls to eval_const_expressions(). This also removes the awkward cross-dependency between relcache.c and index.c. Bug: #15114 Reported-by: Петър Славов <pet.slavov@gmail.com> Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/152110589574.1223.17983600132321618383@wrigleys.postgresql.org/		7 years ago
..
backend	Fix a crash in logical replication	7 years ago
bin	Do not filter by relkind in vacuumdb's catalog query if --table is used	7 years ago
common	Use perfect hashing, instead of binary search, for keyword lookup.	7 years ago
fe_utils	pgbench: add \cset and \gset commands	7 years ago
include	Rename nodes/relation.h to nodes/pathnodes.h.	7 years ago
interfaces	Remove _configthreadlocale() calls in ecpg test suite.	7 years ago
makefiles	Ensure link commands list *.o files before LDFLAGS.	8 years ago
pl	Refactor planner's header files.	7 years ago
port	Use our own getopt() on OpenBSD.	7 years ago
template	…
test	Fix a crash in logical replication	7 years ago
timezone	Replace @postgresql.org with @lists.postgresql.org for mailinglists	7 years ago
tools	Change function call information to be variable length.	7 years ago
tutorial	SQL comment: remove extra word in heading comment	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	fix typo	7 years ago
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	8 years ago
nls-global.mk	Replace @postgresql.org with @lists.postgresql.org for mailinglists	7 years ago