You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane e2e95f5ef3 Fix pg_dump's handling of public schema with both -c and -C options. ... Since -c plus -C requests dropping and recreating the target database as a whole, not dropping individual objects in it, we should assume that the public schema already exists and need not be created. The previous coding considered only the state of the -c option, so it would emit "CREATE SCHEMA public" anyway, leading to an unexpected error in restore. Back-patch to 9.2. Older versions did not accept -c with -C so the issue doesn't arise there. (The logic being patched here dates to 8.0, cf commit 2193121fa, so it's not really wrong that it didn't consider the case at the time.) Note that versions before 9.6 will still attempt to emit REVOKE/GRANT on the public schema; but that happens without -c/-C too, and doesn't seem to be the focus of this complaint. I considered extending this stanza to also skip the public schema's ACL, but that would be a misfeature, as it'd break cases where users intentionally changed that ACL. The real fix for this aspect is Stephen Frost's work to not dump built-in ACLs, and that's not going to get back-ported. Per bugs #13804 and #14271. Solution found by David Johnston and later rediscovered by me. Report: <20151207163520.2628.95990@wrigleys.postgresql.org> Report: <20160801021955.1430.47434@wrigleys.postgresql.org>		10 years ago
..
backend	Minor cleanup for access/transam/parallel.c.	10 years ago
bin	Fix pg_dump's handling of public schema with both -c and -C options.	10 years ago
common	pgindent run for 9.6	10 years ago
fe_utils	Fix comment.	10 years ago
include	Minor cleanup for access/transam/parallel.c.	10 years ago
interfaces	Fixed array checking code for "unsigned long long" datatypes in libecpg.	10 years ago
makefiles	…
pl	Make pltcl regression tests safe for Danish locale.	10 years ago
port	pgindent run for 9.6	10 years ago
template	…
test	Consistently capitalize names of recovery tests	10 years ago
timezone	Reduce stack space consumption in tzload().	10 years ago
tools	Establish conventions about global object names used in regression tests.	10 years ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Provide and use a makefile target to build all generated headers.	10 years ago
Makefile.shlib	Make the AIX case of Makefile.shlib safe for parallel make.	10 years ago
bcc32.mak	…
nls-global.mk	nls-global.mk: search build dir for source files, too	10 years ago
win32.mak	…