You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 72e3abd082 pg_stat_statements: Fix test instability with cache-clobbering builds ... Builds with CLOBBER_CACHE_ALWAYS enabled are failing the new test introduced in 1572ea96e6, checking the nesting level calculation in the planner hook. The inner query of the function called twice is registered as normalized, as such builds would register a PGSS entry in the post-parse-analyse hook due to the cached plans requiring revalidation. A trick based on debug_discard_caches cannot work as far as I can, a normalized query still being registered. This commit takes a different approach with the addition of a DISCARD PLANS before the first function call. This forces the use of a normalized query in the PGSS entry for the inner query of the function with and without CLOBBER_CACHE_ALWAYS, which should be enough to stabilize the test. Note that the test is still checking what it should: when removing the nesting level calculation in the planner hook of PGSS, one still gets a failure for the PGSS entry of the inner query in the function, with "toplevel" being flipped to true instead of false (it should be false, as a non-top-level entry). Per buildfarm members avocet and trilobite, at least. Reported-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/82dd02bb-4e0f-40ad-a60b-baa1763ff0bd@gmail.com		1 month ago
..
cleanup.out	…
cursors.out	Show sizes of FETCH queries as constants in pg_stat_statements	8 months ago
dml.out	Remove the query_id_squash_values GUC	11 months ago
entry_timestamp.out	Track statement entry timestamp in contrib/pg_stat_statements	2 years ago
extended.out	Make query jumbling also squash PARAM_EXTERN params	8 months ago
level_tracking.out	pg_stat_statements: Fix test instability with cache-clobbering builds	1 month ago
oldextversions.out	pg_stat_statements: Add counters for generic and custom plans	7 months ago
parallel.out	pg_stat_statements: Add columns to track parallel worker activity	1 year ago
plancache.out	pg_stat_statements: Add counters for generic and custom plans	7 months ago
planning.out	Revert support for improved tracking of nested queries	9 months ago
privileges.out	pg_stat_statements: Add regression test for privilege handling.	2 years ago
select.out	Fix query jumbling with GROUP BY clauses	2 months ago
squashing.out	pg_stat_statements: Rework test order	1 month ago
user_activity.out	Add NOT NULL checking of pg_stat_statements_reset() in tests	2 years ago
utility.out	Show sizes of FETCH queries as constants in pg_stat_statements	8 months ago
wal.out	Show values of SET statements as constants in pg_stat_statements	1 year ago