You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 6e2c762480 Fix generation of MergeAppend plans for optimized min/max on expressions. ... Before jamming a desired targetlist into a plan node, one really ought to make sure the plan node can handle projections, and insert a buffering Result plan node if not. planagg.c forgot to do this, which is a hangover from the days when it only dealt with IndexScan plan types. MergeAppend doesn't project though, not to mention that it gets unhappy if you remove its possibly-resjunk sort columns. The code accidentally failed to fail for cases in which the min/max argument was a simple Var, because the new targetlist would be equivalent to the original "flat" tlist anyway. For any more complex case, it's been broken since 9.1 where we introduced the ability to optimize min/max using MergeAppend, as reported by Raphael Bauduin. Fix by duplicating the logic from grouping_planner that decides whether we need a Result node. In 9.2 and 9.1, this requires back-porting the tlist_same_exprs() function introduced in commit 4387cf956b, else we'd uselessly add a Result node in cases that worked before. It's rather tempting to back-patch that whole commit so that we can avoid extra Result nodes in mainline cases too; but I'll refrain, since that code hasn't really seen all that much field testing yet.		12 years ago
..
clauses.h	Avoid listing ungrouped Vars in the targetlist of Agg-underneath-Window.	15 years ago
cost.h	Improve cost estimation for aggregates and window functions.	15 years ago
geqo.h	Stamp copyrights for year 2011.	15 years ago
geqo_copy.h	Stamp copyrights for year 2011.	15 years ago
geqo_gene.h	Stamp copyrights for year 2011.	15 years ago
geqo_misc.h	Stamp copyrights for year 2011.	15 years ago
geqo_mutation.h	Stamp copyrights for year 2011.	15 years ago
geqo_pool.h	Stamp copyrights for year 2011.	15 years ago
geqo_random.h	Stamp copyrights for year 2011.	15 years ago
geqo_recombination.h	Stamp copyrights for year 2011.	15 years ago
geqo_selection.h	Stamp copyrights for year 2011.	15 years ago
joininfo.h	Stamp copyrights for year 2011.	15 years ago
pathnode.h	pgindent run before PG 9.1 beta 1.	15 years ago
paths.h	Fix SELECT DISTINCT with index-optimized MIN/MAX on inheritance trees.	13 years ago
placeholder.h	Revisit handling of UNION ALL subqueries with non-Var output columns.	14 years ago
plancat.h	Fix planner to pass correct collation to operator selectivity estimators.	14 years ago
planmain.h	Fix planning of non-strict equivalence clauses above outer joins.	13 years ago
planner.h	Stamp copyrights for year 2011.	15 years ago
predtest.h	Stamp copyrights for year 2011.	15 years ago
prep.h	Stamp copyrights for year 2011.	15 years ago
restrictinfo.h	Stamp copyrights for year 2011.	15 years ago
subselect.h	Fix handling of PlaceHolderVars in nestloop parameter management.	14 years ago
tlist.h	Fix generation of MergeAppend plans for optimized min/max on expressions.	12 years ago
var.h	Avoid listing ungrouped Vars in the targetlist of Agg-underneath-Window.	15 years ago