You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Etsuro Fujita 2bb84ea7ef Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch. ... If inside an EPQ recheck, ExecScanFetch would run the recheck method function for foreign/custom joins even if they aren't descendant nodes in the EPQ recheck plan tree, which is problematic at least in the foreign-join case, because such a foreign join isn't guaranteed to have an alternative local-join plan required for running the recheck method function; in the postgres_fdw case this could lead to a segmentation fault or an assert failure in an assert-enabled build when running the recheck method function. Even if inside an EPQ recheck, any scan nodes that aren't descendant ones in the EPQ recheck plan tree should be normally processed by using the access method function; fix by modifying ExecScanFetch so that if inside an EPQ recheck, it runs the recheck method function for foreign/custom joins that are descendant nodes in the EPQ recheck plan tree as before and runs the access method function for foreign/custom joins that aren't. This fix also adds to postgres_fdw an isolation test for an EPQ recheck that caused issues stated above. Oversight in commit 385f337c9. Reported-by: Kristian Lejao <kristianlejao@gmail.com> Author: Masahiko Sawada <sawada.mshk@gmail.com> Co-authored-by: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com Backpatch-through: 13		2 months ago
..
expected	Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.	2 months ago
specs	Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.	2 months ago
sql	postgres_fdw: Fix tests with ANALYZE and remote sampling	4 months ago
.gitignore	Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.	2 months ago
Makefile	Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.	2 months ago
connection.c	postgres_fdw: re-issue cancel requests a few times if necessary.	1 year ago
deparse.c	Fixup various StringInfo function usages	2 years ago
meson.build	Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.	2 months ago
option.c	Fix Y2038 issues with MyStartTime.	1 year ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add functions to discard cached connections.	5 years ago
postgres_fdw--1.0.sql	…
postgres_fdw.c	Fix memory leakage in postgres_fdw's DirectModify code path.	7 months ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Make dblink interruptible, via new libpqsrv APIs.	2 years ago
shippable.c	Update copyright for 2024	2 years ago