You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alvaro Herrera ebfe2dbd6b Prevent drop of tablespaces used by partitioned relations ... When a tablespace is used in a partitioned relation (per commits ca4103025d in pg12 for tables and 33e6c34c32 in pg11 for indexes), it is possible to drop the tablespace, potentially causing various problems. One such was reported in bug #16577, where a rewriting ALTER TABLE causes a server crash. Protect against this by using pg_shdepend to keep track of tablespaces when used for relations that don't keep physical files; we now abort a tablespace if we see that the tablespace is referenced from any partitioned relations. Backpatch this to 11, where this problem has been latent all along. We don't try to create pg_shdepend entries for existing partitioned indexes/tables, but any ones that are modified going forward will be protected. Note slight behavior change: when trying to drop a tablespace that contains both regular tables as well as partitioned ones, you'd previously get ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE and now you'll get ERRCODE_DEPENDENT_OBJECTS_STILL_EXIST. Arguably, the latter is more correct. It is possible to add protecting pg_shdepend entries for existing tables/indexes, by doing ALTER TABLE ONLY some_partitioned_table SET TABLESPACE pg_default; ALTER TABLE ONLY some_partitioned_table SET TABLESPACE original_tablespace; for each partitioned table/index that is not in the database default tablespace. Because these partitioned objects do not have storage, no file needs to be actually moved, so it shouldn't take more time than what's required to acquire locks. This query can be used to search for such relations: SELECT ... FROM pg_class WHERE relkind IN ('p', 'I') AND reltablespace <> 0 Reported-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/16577-881633a9f9894fd5@postgresql.org Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Michael Paquier <michael@paquier.xyz>		5 years ago
..
backend	Prevent drop of tablespaces used by partitioned relations	5 years ago
bin	Improve tab-completion for CLOSE, DECLARE, FETCH and MOVE.	5 years ago
common	Rework refactoring of hex and encoding routines	5 years ago
fe_utils	Update copyright for 2021	5 years ago
include	Prevent drop of tablespaces used by partitioned relations	5 years ago
interfaces	Try next host after a "cannot connect now" failure.	5 years ago
makefiles	…
pl	Fix plpgsql tests for debug_invalidate_system_caches_always.	5 years ago
port	Move our p{read,write}v replacements into their own files.	5 years ago
template	On macOS, use -isysroot in link steps as well as compile steps.	5 years ago
test	Prevent drop of tablespaces used by partitioned relations	5 years ago
timezone	Update copyright for 2021	5 years ago
tools	Rework refactoring of hex and encoding routines	5 years ago
tutorial	Doc, more or less: uncomment tutorial example that was fixed long ago.	5 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Remove the option to build thread_test.c outside configure.	5 years ago
Makefile.global.in	Split Makefile symbol CFLAGS_VECTOR into two symbols.	5 years ago
Makefile.shlib	…
nls-global.mk	…