You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Masahiko Sawada cf2c69ec5a Fix possibility of logical decoding partial transaction changes. ... When creating and initializing a logical slot, the restart_lsn is set to the latest WAL insertion point (or the latest replay point on standbys). Subsequently, WAL records are decoded from that point to find the start point for extracting changes in the DecodingContextFindStartpoint() function. Since the initial restart_lsn could be in the middle of a transaction, the start point must be a consistent point where we won't see the data for partial transactions. Previously, when not building a full snapshot, serialized snapshots were restored, and the SnapBuild jumps to the consistent state even while finding the start point. Consequently, the slot's restart_lsn and confirmed_flush could be set to the middle of a transaction. This could lead to various unexpected consequences. Specifically, there were reports of logical decoding decoding partial transactions, and assertion failures occurred because only subtransactions were decoded without decoding their top-level transaction until decoding the commit record. To resolve this issue, the changes prevent restoring the serialized snapshot and jumping to the consistent state while finding the start point. On v17 and HEAD, a flag indicating whether snapshot restores should be skipped has been added to the SnapBuild struct, and SNAPBUILD_VERSION has been bumpded. On backbranches, the flag is stored in the LogicalDecodingContext instead, preserving on-disk compatibility. Backpatch to all supported versions. Reported-by: Drew Callahan Reviewed-by: Amit Kapila, Hayato Kuroda Discussion: https://postgr.es/m/2444AA15-D21B-4CCE-8052-52C7C2DAFE5C%40amazon.com Backpatch-through: 12		1 year ago
..
binary.out	…
catalog_change_snapshot.out	Fix assertion failures while processing NEW_CID record in logical decoding.	3 years ago
concurrent_ddl_dml.out	Improve display of query results in isolation tests.	4 years ago
ddl.out	Introduce xid8-based functions to replace txid_XXX.	6 years ago
decoding_in_xact.out	Introduce xid8-based functions to replace txid_XXX.	6 years ago
decoding_into_rel.out	…
delayed_startup.out	Improve display of query results in isolation tests.	4 years ago
messages.out	…
mxact.out	Improve display of query results in isolation tests.	4 years ago
oldest_xmin.out	Improve display of query results in isolation tests.	4 years ago
ondisk_startup.out	Improve display of query results in isolation tests.	4 years ago
permissions.out	…
prepared.out	…
replorigin.out	Remove assertion for replication origins in PREPARE TRANSACTION	4 years ago
rewrite.out	Fix regression tests to use only global names beginning with "regress_".	6 years ago
skip_snapshot_restore.out	Fix possibility of logical decoding partial transaction changes.	1 year ago
slot.out	Check slot->restart_lsn validity in a few more places	5 years ago
snapshot_transfer.out	Improve display of query results in isolation tests.	4 years ago
spill.out	…
subxact_without_top.out	Improve display of query results in isolation tests.	4 years ago
time.out	…
toast.out	WAL log unchanged toasted replica identity key attributes.	4 years ago
truncate.out	…
xact.out	…