You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane ec7b89cc53 Ensure that pg_amop/amproc entries depend on their lefttype/righttype. ... Usually an entry in pg_amop or pg_amproc does not need a dependency on its amoplefttype/amoprighttype/amproclefttype/amprocrighttype types, because there is an indirect dependency via the argument types of its referenced operator or procedure, or via the opclass it belongs to. However, for some support procedures in some index AMs, the argument types of the support procedure might not mention the column data type at all. Also, the amop/amproc entry might be treated as "loose" in the opfamily, in which case it lacks a dependency on any particular opclass; or it might be a cross-type entry having a reference to a datatype that is not its opclass' opcintype. The upshot of all this is that there are cases where a datatype can be dropped while leaving behind amop/amproc entries that mention it, because there is no path in pg_depend showing that those entries depend on that type. Such entries are harmless in normal activity, because they won't get used, but they cause problems for maintenance actions such as dropping the operator family. They also cause pg_dump to produce bogus output. The previous commit put a band-aid on the DROP OPERATOR FAMILY failure, but a real fix is needed. To fix, add pg_depend entries showing that a pg_amop/pg_amproc entry depends on its lefttype/righttype. To avoid bloating pg_depend too much, skip this if the referenced operator or function has that type as an input type. (I did not bother with considering the possible indirect dependency via the opclass' opcintype; at least in the reported case, that wouldn't help anyway.) Probably, the reason this has escaped notice for so long is that add-on datatypes and relevant opclasses/opfamilies are usually packaged as extensions nowadays, so that there's no way to drop a type without dropping the referencing opclasses/opfamilies too. Still, in the absence of pg_depend entries there's nothing that constrains DROP EXTENSION to drop the opfamily entries before the datatype, so it seems possible for a DROP failure to occur anyway. The specific case that was reported doesn't fail in v13, because v13 prefers to attach the support procedure to the opclass not the opfamily. But it's surely possible to construct other edge cases that do fail in v13, so patch that too. Per report from Yoran Heling. Back-patch to all supported branches. Discussion: https://postgr.es/m/Z1MVCOh1hprjK5Sf@gmai021		1 year ago
..
backend	Ensure that pg_amop/amproc entries depend on their lefttype/righttype.	1 year ago
bin	psql: Add tab completion for COPY (MERGE ...	1 year ago
common	Clean up newlines following left parentheses	1 year ago
fe_utils	Prevent mis-encoding of "trailing junk after numeric literal" errors.	1 year ago
include	Ensure that pg_amop/amproc entries depend on their lefttype/righttype.	1 year ago
interfaces	Fix broken list-munging in ecpg's remove_variables().	1 year ago
makefiles	…
pl	Add support for Tcl 9	1 year ago
port	Fix overflow in bsearch_arg() with more than INT_MAX elements	1 year ago
template	…
test	Fix is_digit labeling of to_timestamp's FFn format codes.	1 year ago
timezone	Update time zone data files to tzdata release 2024b.	1 year ago
tools	Avoid mislabeling of lateral references, redux.	1 year ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	…
Makefile.shlib	…
meson.build	…
nls-global.mk	…