You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 55dc86eca7 Fix pull_varnos' miscomputation of relids set for a PlaceHolderVar. ... Previously, pull_varnos() took the relids of a PlaceHolderVar as being equal to the relids in its contents, but that fails to account for the possibility that we have to postpone evaluation of the PHV due to outer joins. This could result in a malformed plan. The known cases end up triggering the "failed to assign all NestLoopParams to plan nodes" sanity check in createplan.c, but other symptoms may be possible. The right value to use is the join level we actually intend to evaluate the PHV at. We can get that from the ph_eval_at field of the associated PlaceHolderInfo. However, there are some places that call pull_varnos() before the PlaceHolderInfos have been created; in that case, fall back to the conservative assumption that the PHV will be evaluated at its syntactic level. (In principle this might result in missing some legal optimization, but I'm not aware of any cases where it's an issue in practice.) Things are also a bit ticklish for calls occurring during deconstruct_jointree(), but AFAICS the ph_eval_at fields should have reached their final values by the time we need them. The main problem in making this work is that pull_varnos() has no way to get at the PlaceHolderInfos. We can fix that easily, if a bit tediously, in HEAD by passing it the planner "root" pointer. In the back branches that'd cause an unacceptable API/ABI break for extensions, so leave the existing entry points alone and add new ones with the additional parameter. (If an old entry point is called and encounters a PHV, it'll fall back to using the syntactic level, again possibly missing some valid optimization.) Back-patch to v12. The computation is surely also wrong before that, but it appears that we cannot reach a bad plan thanks to join order restrictions imposed on the subquery that the PlaceHolderVar came from. The error only became reachable when commit 4be058fe9 allowed trivial subqueries to be collapsed out completely, eliminating their join order restrictions. Per report from Stephan Springl. Discussion: https://postgr.es/m/171041.1610849523@sss.pgh.pa.us		4 years ago
..
expected	Implement support for bulk inserts in postgres_fdw	5 years ago
sql	Implement support for bulk inserts in postgres_fdw	5 years ago
.gitignore	Add postgres_fdw contrib module.	13 years ago
Makefile	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
connection.c	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
deparse.c	Implement support for bulk inserts in postgres_fdw	5 years ago
option.c	Implement support for bulk inserts in postgres_fdw	5 years ago
postgres_fdw--1.0--1.1.sql	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw--1.0.sql	Add postgres_fdw contrib module.	13 years ago
postgres_fdw.c	Fix pull_varnos' miscomputation of relids set for a PlaceHolderVar.	4 years ago
postgres_fdw.control	postgres_fdw: Add function to list cached connections to foreign servers.	5 years ago
postgres_fdw.h	Implement support for bulk inserts in postgres_fdw	5 years ago
shippable.c	Replace remaining uses of "whitelist".	5 years ago