You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 5b64368742 Fix incautious handling of possibly-miscoded strings in client code. ... An incorrectly-encoded multibyte character near the end of a string could cause various processing loops to run past the string's terminating NUL, with results ranging from no detectable issue to a program crash, depending on what happens to be in the following memory. This isn't an issue in the server, because we take care to verify the encoding of strings before doing any interesting processing on them. However, that lack of care leaked into client-side code which shouldn't assume that anyone has validated the encoding of its input. Although this is certainly a bug worth fixing, the PG security team elected not to regard it as a security issue, primarily because any untrusted text should be sanitized by PQescapeLiteral or the like before being incorporated into a SQL or psql command. (If an app fails to do so, the same technique can be used to cause SQL injection, with probably much more dire consequences than a mere client-program crash.) Those functions were already made proof against this class of problem, cf CVE-2006-2313. To fix, invent PQmblenBounded() which is like PQmblen() except it won't return more than the number of bytes remaining in the string. In HEAD we can make this a new libpq function, as PQmblen() is. It seems imprudent to change libpq's API in stable branches though, so in the back branches define PQmblenBounded as a macro in the files that need it. (Note that just changing PQmblen's behavior would not be a good idea; notably, it would completely break the escaping functions' defense against this exact problem. So we just want a version for those callers that don't have any better way of handling this issue.) Per private report from houjingyi. Back-patch to all supported branches.		4 years ago
..
backend	Reduce risks of conflicts in internal queries of REFRESH MATVIEW CONCURRENTLY	4 years ago
bin	Fix incautious handling of possibly-miscoded strings in client code.	4 years ago
common	Fix incautious handling of possibly-miscoded strings in client code.	4 years ago
fe_utils	Fix incautious handling of possibly-miscoded strings in client code.	4 years ago
include	Fix incautious handling of possibly-miscoded strings in client code.	4 years ago
interfaces	Fix incautious handling of possibly-miscoded strings in client code.	4 years ago
makefiles	Remove libpq.rc, use win32ver.rc for libpq	6 years ago
pl	Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.	4 years ago
port	Add fallback implementation for setenv()	4 years ago
template	Further tweaking of PG_SYSROOT heuristics for macOS.	5 years ago
test	In PostgresNode.pm, don't pass SQL to psql on the command line	4 years ago
timezone	Update time zone data files to tzdata release 2021a.	5 years ago
tools	Add fallback implementation for setenv()	4 years ago
tutorial	tutorial: land height is "elevation", not "altitude"	5 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Update Unicode data to Unicode 13.0.0 and CLDR 37	5 years ago
Makefile.shlib	Add PostgreSQL home page to --help output	6 years ago
nls-global.mk	NLS: Fix backend gettext triggers	6 years ago