You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 529ebb20aa Generate EquivalenceClass members for partitionwise child join rels. ... Commit d25ea0127 got rid of what I thought were entirely unnecessary derived child expressions in EquivalenceClasses for EC members that mention multiple baserels. But it turns out that some of the child expressions that code created are necessary for partitionwise joins, else we fail to find matching pathkeys for Sort nodes. (This happens only for certain shapes of the resulting plan; it may be that partitionwise aggregation is also necessary to show the failure, though I'm not sure of that.) Reverting that commit entirely would be quite painful performance-wise for large partition sets. So instead, add code that explicitly generates child expressions that match only partitionwise child join rels we have actually generated. Per report from Justin Pryzby. (Amit Langote noticed the problem earlier, though it's not clear if he recognized then that it could result in a planner error, not merely failure to exploit partitionwise join, in the code as-committed.) Back-patch to v12 where commit d25ea0127 came in. Amit Langote, with lots of kibitzing from me Discussion: https://postgr.es/m/CA+HiwqG2WVUGmLJqtR0tPFhniO=H=9qQ+Z3L_ZC+Y3-EVQHFGg@mail.gmail.com Discussion: https://postgr.es/m/20191011143703.GN10470@telsasoft.com		6 years ago
..
appendinfo.h	Phase 2 pgindent run for v12.	7 years ago
clauses.h	Phase 2 pgindent run for v12.	7 years ago
cost.h	Fix many typos and inconsistencies	7 years ago
geqo.h	Phase 2 pgindent run for v12.	7 years ago
geqo_copy.h	Update copyright for 2019	7 years ago
geqo_gene.h	Update copyright for 2019	7 years ago
geqo_misc.h	Update copyright for 2019	7 years ago
geqo_mutation.h	Update copyright for 2019	7 years ago
geqo_pool.h	Update copyright for 2019	7 years ago
geqo_random.h	Update copyright for 2019	7 years ago
geqo_recombination.h	Phase 2 pgindent run for v12.	7 years ago
geqo_selection.h	Phase 2 pgindent run for v12.	7 years ago
inherit.h	Phase 2 pgindent run for v12.	7 years ago
joininfo.h	Phase 2 pgindent run for v12.	7 years ago
optimizer.h	Phase 2 pgindent run for v12.	7 years ago
orclauses.h	Rename nodes/relation.h to nodes/pathnodes.h.	7 years ago
paramassign.h	Phase 2 pgindent run for v12.	7 years ago
pathnode.h	Cosmetic improvements in setup of planner's per-RTE arrays.	6 years ago
paths.h	Generate EquivalenceClass members for partitionwise child join rels.	6 years ago
placeholder.h	Fix more typos and inconsistencies in the tree	7 years ago
plancat.h	Phase 2 pgindent run for v12.	7 years ago
planmain.h	Phase 2 pgindent run for v12.	7 years ago
planner.h	Phase 2 pgindent run for v12.	7 years ago
prep.h	Allow functions-in-FROM to be pulled up if they reduce to constants.	6 years ago
restrictinfo.h	Phase 2 pgindent run for v12.	7 years ago
subselect.h	Phase 2 pgindent run for v12.	7 years ago
tlist.h	Phase 2 pgindent run for v12.	7 years ago