You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane f07a3039c7 Ensure we preprocess expressions before checking their volatility. ... contain_mutable_functions and contain_volatile_functions give reliable answers only after expression preprocessing (specifically eval_const_expressions). Some places understand this, but some did not get the memo --- which is not entirely their fault, because the problem is documented only in places far away from those functions. Introduce wrapper functions that allow doing the right thing easily, and add commentary in hopes of preventing future mistakes from copy-and-paste of code that's only conditionally safe. Two actual bugs of this ilk are fixed here. We failed to preprocess column GENERATED expressions before checking mutability, so that the code could fail to detect the use of a volatile function default-argument expression, or it could reject a polymorphic function that is actually immutable on the datatype of interest. Likewise, column DEFAULT expressions weren't preprocessed before determining if it's safe to apply the attmissingval mechanism. A false negative would just result in an unnecessary table rewrite, but a false positive could allow the attmissingval mechanism to be used in a case where it should not be, resulting in unexpected initial values in a new column. In passing, re-order the steps in ComputePartitionAttrs so that its checks for invalid column references are done before applying expression_planner, rather than after. The previous coding would not complain if a partition expression contains a disallowed column reference that gets optimized away by constant folding, which seems to me to be a behavior we do not want. Per bug #18097 from Jim Keener. Back-patch to all supported versions. Discussion: https://postgr.es/m/18097-ebb179674f22932f@postgresql.org		2 years ago
..
backend	Ensure we preprocess expressions before checking their volatility.	2 years ago
bin	Don't try to dump RLS policies or security labels for extension objects.	2 years ago
common	Improve pglz_decompress's defenses against corrupt compressed data.	2 years ago
fe_utils	Don't spuriously report FD_SETSIZE exhaustion on Windows.	2 years ago
include	Ensure we preprocess expressions before checking their volatility.	2 years ago
interfaces	Call pqPipelineFlush from PQsendFlushRequest	2 years ago
makefiles	Use --strip-unneeded when stripping static libraries with GNU strip.	2 years ago
pl	Translation updates	2 years ago
port	Meson: check for pg_config_paths.h left over from make	2 years ago
template	Use unnamed POSIX semaphores on Cygwin.	3 years ago
test	Ensure we preprocess expressions before checking their volatility.	2 years ago
timezone	Remove PHOT from our default timezone abbreviations list.	2 years ago
tools	Ensure we use the correct spelling of "ensure"	2 years ago
tutorial	Pre-beta mechanical code beautification.	2 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
Makefile.global.in	Suppress macOS warnings about duplicate libraries in link commands.	2 years ago
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2 years ago
meson.build	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
nls-global.mk	…