You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Rowley f0efa5aec1 Introduce the concept of read-only StringInfos ... There were various places in our codebase which conjured up a StringInfo by manually assigning the StringInfo fields and setting the data field to point to some existing buffer. There wasn't much consistency here as to what fields like maxlen got set to and in one location we didn't correctly ensure that the buffer was correctly NUL terminated at len bytes, as per what was documented as required in stringinfo.h Here we introduce 2 new functions to initialize StringInfos. One allows callers to initialize a StringInfo passing along a buffer that is already allocated by palloc. Here the StringInfo code uses this buffer directly rather than doing any memcpying into a new allocation. Having this as a function allows us to verify the buffer is correctly NUL terminated. StringInfos initialized this way can be appended to and reset just like any other normal StringInfo. The other new initialization function also accepts an existing buffer, but the given buffer does not need to be a pointer to a palloc'd chunk. This buffer could be a pointer pointing partway into some palloc'd chunk or may not even be palloc'd at all. StringInfos initialized this way are deemed as "read-only". This means that it's not possible to append to them or reset them. For the latter of the two new initialization functions mentioned above, we relax the requirement that the data buffer must be NUL terminated. Relaxing this requirement is convenient in a few places as it can save us from having to allocate an entire new buffer just to add the NUL terminator or save us from having to temporarily add a NUL only to have to put the original char back again later. Incompatibility note: Here we also forego adding the NUL in a few places where it does not seem to be required. These locations are passing the given StringInfo into a type's receive function. It does not seem like any of our built-in receive functions require this, but perhaps there's some UDT out there in the wild which does require this. It is likely worthy of a mention in the release notes that a UDT's receive function mustn't rely on the input StringInfo being NUL terminated. Author: David Rowley Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CAApHDvorfO3iBZ%3DxpiZvp3uHtJVLyFaPBSvcAhAq2HPLnaNSwQ%40mail.gmail.com		2 years ago
..
access	Assert that buffers are marked dirty before XLogRegisterBuffer().	2 years ago
archive	…
backup	Change struct tablespaceinfo's oid member from 'char *' to 'Oid'	2 years ago
bootstrap	Refactor InitPostgres() to use bitwise option flags	2 years ago
catalog	Allow ALTER SYSTEM to set unrecognized custom GUCs.	2 years ago
commands	Make some error strings more generic	2 years ago
executor	Fix problems when a plain-inheritance parent table is excluded.	2 years ago
foreign	Expand some more uses of "deleg" to "delegation" or "delegated".	3 years ago
jit	jit: Changes for LLVM 17.	2 years ago
lib	Make binaryheap available to frontend code.	2 years ago
libpq	Refactor ListenSocket array.	2 years ago
main	Remove obsolete defense against strxfrm() bugs.	3 years ago
nodes	Remove IndexInfo.ii_OpclassOptions field	2 years ago
optimizer	Prevent duplicate RTEPermissionInfo for plain-inheritance parents	2 years ago
parser	Extend ALTER OPERATOR to allow setting more optimization attributes.	2 years ago
partitioning	Fix incorrect step generation in HASH partition pruning	2 years ago
po	Translation updates	2 years ago
port	Add GUC parameter "huge_pages_status"	3 years ago
postmaster	Avoid calling proc_exit() in processes forked by system().	2 years ago
regex	All supported systems have locale_t.	3 years ago
replication	Introduce the concept of read-only StringInfos	2 years ago
rewrite	Add TupleDescGetDefault()	2 years ago
snowball	Fix the install rule for snowball_create.sql.	3 years ago
statistics	Take pg_attribute out of VacAttrStats	3 years ago
storage	Assert that buffers are marked dirty before XLogRegisterBuffer().	2 years ago
tcop	Introduce the concept of read-only StringInfos	2 years ago
tsearch	Limit to_tsvector_byid's initial array allocation to something sane.	2 years ago
utils	Introduce the concept of read-only StringInfos	2 years ago
.gitignore	…
Makefile	Add system view pg_wait_events	2 years ago
common.mk	…
meson.build	Add win32ver data to meson-built postgres.exe.	3 years ago
nls.mk	Add missing gettext triggers	3 years ago